Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show correct log for outbound message #272

Merged
merged 11 commits into from
Dec 14, 2022
Merged

fix: show correct log for outbound message #272

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5e83dd1
fix: show correct message for outbound message
Souvikns Mar 14, 2022
8be911f
chore: lint fix
Souvikns Mar 14, 2022
6ebad87
Merge remote-tracking branch 'upstream/master' into log-fix
Souvikns Dec 6, 2022
87961ec
fix: correct log according to client and server
Souvikns Dec 8, 2022
3ed9828
fix: update examples and outbound logger
Souvikns Dec 8, 2022
ae90485
refactor: fix examples
Souvikns Dec 8, 2022
f1e2929
refactor: clean code
Souvikns Dec 8, 2022
bf9bb3b
refactor: removing unrelated changes
Souvikns Dec 12, 2022
02fe581
refactor: remove unrelated code
Souvikns Dec 12, 2022
cb57b0c
refactor: remove newline conflict
Souvikns Dec 12, 2022
5879379
refactor: simplify functions
Souvikns Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions examples/social-network/websocket-server/functions/onLikeDislike.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,18 @@ export default async function (event) {
},
}
}],
reply: [
Souvikns marked this conversation as resolved.
Show resolved Hide resolved
{
channel: '/',
payload: {
type: 'likes_count_updated',
data: {
postId,
totalCount
}
}
}
],
Souvikns marked this conversation as resolved.
Show resolved Hide resolved
...(
type === 'like' && {
send: [{
Expand Down
4 changes: 2 additions & 2 deletions examples/social-network/websocket-server/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion src/lib/logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,14 @@ export const logInboundMessage = (message: GleeMessage) => {
}

export const logOutboundMessage = (message: GleeMessage) => {
let verb: string
const event = message.eventNames()[0]
const icon = message.broadcast ? '⇶' : '↗'
const verb = message.broadcast ? 'broadcasted' : 'sent'
if (message.serverName === 'websockets' && event !== 'reply') {
Souvikns marked this conversation as resolved.
Show resolved Hide resolved
verb = 'broadcasted'
} else {
verb = 'sent'
}
const serverName = message.serverName || 'all servers'
console.log(chalk.reset.magenta(icon), chalk.yellow(message.channel), 'was', verb ,'to', chalk.gray(serverName))
logJSON(message.payload)
Expand Down