-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate to typescript round 1 #212
feat: migrate to typescript round 1 #212
Conversation
public rawConnection: any | ||
public channels: string[] | ||
public serverName: string | ||
public AsyncAPIServer: AsyncAPIServer | ||
public parsedAsyncAPI: AsyncAPIDocument |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll make this stuff private in the next PR. I want to leave it public so it behaves the same way as in JS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public payload: any | ||
public headers: Map<string, string> | ||
public channel: string | ||
public serverName: string | ||
public connection: GleeConnection | ||
public broadcast: boolean | ||
public __isGleeMessage: boolean | ||
public inbound: boolean | ||
public outbound: boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll make this stuff private in the next PR. I want to leave it public so it behaves the same way as in JS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fmvilas you have some conflicts 🙂 |
@jonaslagoni conflicts solved. Thanks for the heads up! |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/rtm |
@jonaslagoni can you approve again, please? |
/rtm |
🎉 This PR is included in version 0.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Related issue(s)
#144