Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use latest arborist 6 and drop support for node 12 and 14 #925

Closed
wants to merge 2 commits into from

Conversation

derberg
Copy link
Member

@derberg derberg commented Mar 23, 2023

BREAKING CHANGE:

tl;dr the only breaking change is that you will no longer be able to install Generator when using Node 12 or 14. This will break pipelines for people.

We need to explicitly require:

  "engines": {
    "node": "^14.17.0 || ^16.13.0 || >=18.0.0"
  },

Because this is what latest Arborist requires.

Node 12 is already not maintained by node folks, and Node 14 support finishes on April 30, this is why I suggest to also not support Node 14.


TODO: this PR cannot be merged before we update global pipelines to run on Node 16. Different story though. Review and approval of this PR is not blocked by this. You only need to know that this is why tests fail

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do it!

@D1X7R4
Copy link

D1X7R4 commented May 22, 2023

Hi!

Is there any progress on this?

Thanks in advance.

Copy link
Member Author

derberg commented May 23, 2023

@D1X7R4 why, do you need this chang?

@D1X7R4
Copy link

D1X7R4 commented May 24, 2023

Snyk vulnerabilities findings
Screenshot 2023-05-24 at 14 45 24

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@derberg
Copy link
Member Author

derberg commented Jan 17, 2024

@D1X7R4 fyi I'm dropping this PR. #1061 should solve what you need. I found that one major version less of Arborist will not drop node 12 support - so linked PR will use it for now. Jumping from version 2.2.4 to 5.6.3 should solve many security issues

@derberg derberg closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants