Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Florence and Pratik as contributors and also codeowners #891

Merged
merged 4 commits into from
Jan 12, 2023

Conversation

derberg
Copy link
Member

@derberg derberg commented Dec 20, 2022

Description

@fmvilas @magicmatatjahu @jonaslagoni folks I want to suggest @Florence-Njeri and @pratik2315 as maintainers for generator documentations. Over the last few months, they participated in Google Season of Docs, reworked our docs, demonstrated good understanding of the generator, they also started participating in ongoing PRs as reviewers.

Additionally:

both Florence and Pratik shared that they want to stay with AsyncAPI community and learn more about technical writing and help maintain docs for the generator.

cc @alequetzalli
Congrats Alejandra! you brought great people into the project through GSoD 👏🏼

@Florence-Njeri and @pratik2315 please share in the PR if you agree to be maintainers. If yes, as I shared with you, you can also become TSC members fro entire initiative. Once this PR is merged you can open a PR and update https://github.com/asyncapi/community/blob/master/TSC_MEMBERS.json to put your names there. Example PR -> asyncapi/community#510

@pratik9315
Copy link
Contributor

Hey there @derberg ! I would be honored to be part of this community and help it grow both as a maintainer and a TSC member🙏

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💜💜💜

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🔥

@Florence-Njeri
Copy link
Collaborator

Hey @derberg, I'd be honored to be a maintainer for the docs and also a TSC member.

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it makes a lot of sense 👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member Author

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Florence-Njeri @pratik2315 looks like the voting ended up well 😄

I'm merging this PR. You will soon get invite from GitHub to join AsyncAPI org as maintainers in this repo. I will add you to TSC-related team as well. You can go ahead and add yourself to https://github.com/asyncapi/community/blob/master/TSC_MEMBERS.json (can be in one PR)

@derberg
Copy link
Member Author

derberg commented Jan 12, 2023

/rtm 🚀

@asyncapi-bot asyncapi-bot merged commit f0daa47 into asyncapi:master Jan 12, 2023
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.9.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants