-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add Florence and Pratik as contributors and also codeowners #891
Conversation
Hey there @derberg ! I would be honored to be part of this community and help it grow both as a maintainer and a TSC member🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💜💜💜
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🔥
Hey @derberg, I'd be honored to be a maintainer for the docs and also a TSC member. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it makes a lot of sense 👍
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Florence-Njeri @pratik2315 looks like the voting ended up well 😄
I'm merging this PR. You will soon get invite from GitHub to join AsyncAPI org as maintainers in this repo. I will add you to TSC-related team as well. You can go ahead and add yourself to https://github.com/asyncapi/community/blob/master/TSC_MEMBERS.json (can be in one PR)
/rtm 🚀 |
🎉 This PR is included in version 1.9.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
@fmvilas @magicmatatjahu @jonaslagoni folks I want to suggest @Florence-Njeri and @pratik2315 as maintainers for generator documentations. Over the last few months, they participated in Google Season of Docs, reworked our docs, demonstrated good understanding of the generator, they also started participating in ongoing PRs as reviewers.
Additionally:
both Florence and Pratik shared that they want to stay with AsyncAPI community and learn more about technical writing and help maintain docs for the generator.
cc @alequetzalli
Congrats Alejandra! you brought great people into the project through GSoD 👏🏼
@Florence-Njeri and @pratik2315 please share in the PR if you agree to be maintainers. If yes, as I shared with you, you can also become TSC members fro entire initiative. Once this PR is merged you can open a PR and update https://github.com/asyncapi/community/blob/master/TSC_MEMBERS.json to put your names there. Example PR -> asyncapi/community#510