feat: add templatesDir option to getTemplateFile #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
🎉 This PR is included in version 0.37.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you're using the generator as a library, your application's
node_moduleswill be different than the defaultDEFAULT_TEMPLATES_DIR. For instance:If I use the generator as a library in this scenario,
DEFAULT_TEMPLATES_DIRwould bemy-app/node_modules/@asyncapi/generator/and using the@asyncapi/html-templatewould result in the template being installed as a sibling of the generator, like above. Therefore, usinggetTemplateFile('@asyncapi/html', 'partials/content.html')will result in an attempt to access the filemy-app/node_modules/@asyncapi/generator/node_modules/@asyncapi/html-template/partials/content.html, which is incorrect.This PR lets you change the
DEFAULT_TEMPLATES_DIRonly for thegetTemplateFilemethod.