Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register optional schema parsers #247

Merged
merged 2 commits into from
Mar 16, 2020

Conversation

fmvilas
Copy link
Member

@fmvilas fmvilas commented Mar 11, 2020

After extracting RAML and OpenAPI schema parsers from the JS parser, we must register them explicitly now.

@fmvilas fmvilas requested review from derberg and jonaslagoni March 11, 2020 17:37
@derberg
Copy link
Member

derberg commented Mar 11, 2020

@fmvilas I guess we are waiting with this one for parser-js release and you will have to bump version of it in generator?

@fmvilas
Copy link
Member Author

fmvilas commented Mar 11, 2020

There's no need to wait, @derberg. The schema parsers are the same and registering twice doesn't make any harm.

@derberg
Copy link
Member

derberg commented Mar 11, 2020

@fmvilas I have mixed feelings about it, we are not in a rush and can wait, or?

@fmvilas
Copy link
Member Author

fmvilas commented Mar 11, 2020

We can wait for merging but not necessarily approving 😄

The parser PR doesn't introduce any breaking change in the API. What we're doing here is comparable to:

let a;
a = 10
...
a = 10

You see a is assigned twice but it doesn't really make any difference :)

@derberg
Copy link
Member

derberg commented Mar 11, 2020

Sure, approval, of course, once the parser version is bumped 😈

@fmvilas fmvilas self-assigned this Mar 12, 2020
@fmvilas fmvilas added this to the Make Generator stable milestone Mar 13, 2020
@fmvilas
Copy link
Member Author

fmvilas commented Mar 16, 2020

Can we approve this now? 😄 👉 https://github.com/asyncapi/parser-js/releases/tag/v0.15.0

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 🚀

@fmvilas fmvilas merged commit 2cbb2d6 into asyncapi:master Mar 16, 2020
@fmvilas fmvilas deleted the register-optional-schema-parsers branch March 16, 2020 12:08
@fmvilas
Copy link
Member Author

fmvilas commented Mar 16, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants