-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register optional schema parsers #247
Register optional schema parsers #247
Conversation
@fmvilas I guess we are waiting with this one for |
There's no need to wait, @derberg. The schema parsers are the same and registering twice doesn't make any harm. |
@fmvilas I have mixed feelings about it, we are not in a rush and can wait, or? |
We can wait for merging but not necessarily approving 😄 The parser PR doesn't introduce any breaking change in the API. What we're doing here is comparable to: let a;
a = 10
...
a = 10 You see |
Can we approve this now? 😄 👉 https://github.com/asyncapi/parser-js/releases/tag/v0.15.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done 🚀
Thanks! |
After extracting RAML and OpenAPI schema parsers from the JS parser, we must register them explicitly now.