Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert templates in packages #219
Convert templates in packages #219
Changes from 7 commits
a4448e6
fca24e5
82c81b7
c8fd0f7
ba82d98
3c15ef0
f716fad
4334819
3edba4c
36f4e53
8f1afc3
9aced52
7076b3e
4022a08
de31ff6
c9cc3c0
27c2c80
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added those suggestions to explain the flag as at first it was weird for me that there is a
--force-install
flag but I did not pass it and dependencies were installed anyway (at first run). Maybe the name is confusing, maybereinstall
or something 🤔btw, why no
-f
flag?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
-f
flag will be a generic--force
flag. It would "force" everything. Including, for instance, the generation when the repo has unstaged changes. It's useful but it's probably another flag and another PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeap, since last release we have
--force-write
so--force-install
now nicely adds to the list and then as you wrote we can have-f
god to apply all force flagsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add code comment here what we are protecting from here as I couldn't figure out why,
I ran all templates and was never able to get
true
for any file. I see proper protection is here https://github.com/asyncapi/generator/blob/master/lib/generator.js#L379There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the only place where
generateFile
is called, that's why. I should probably remove it from the line you mentioned.