-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add compile
option to enable rerun of transpilation for react templates
#1177
Merged
+143
−10
Merged
Changes from 27 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
bbe0a7b
added a compile option to enable skipping default transpilation
Gmin2 565eefb
updated jsdoc and implemented conditional transpilation in configureT…
Gmin2 cb0ca24
added some changes
Gmin2 ef94410
added integration testing for compile flag
Gmin2 492814e
added a compile option to enable skipping default transpilation
Gmin2 77cc9d1
updated jsdoc and implemented conditional transpilation in configureT…
Gmin2 d5c986c
rebased:added some changes
Gmin2 237b14a
remove integration test
Gmin2 830d195
fixed linting problem
Gmin2 13aea56
added console logs in configureReact and added test
Gmin2 792fc3c
added the integration test and cleanup
Gmin2 1dbf3db
remove the unit test
Gmin2 b4037f4
remove temp.md
Gmin2 cee60c2
added integration test to be created during the testing
Gmin2 d4589aa
cleanup
Gmin2 0407e86
updated the test
Gmin2 d3f1ba9
make the reviewed changes
Gmin2 ebbf27e
fixed linting prob
Gmin2 39169e0
removed the `__transpiled` folder content for cleanup of test
Gmin2 0245b65
renamed the corrected name
Gmin2 b3df084
Merge branch 'master' into compile
derberg cd52244
Merge remote-tracking branch 'upstream/master' into compile
Gmin2 d31e67b
fixed conflicts
Gmin2 b864bd1
Merge branch 'compile' of https://github.com/utnim2/generator into co…
Gmin2 65ee591
fixed conflict
Gmin2 c7323d9
removedd the catch block
Gmin2 5bd97e1
Merge remote-tracking branch 'upstream/master' into compile
Gmin2 da7cc75
Merge branch 'master' into compile
derberg 2f6e74f
tests: update tests
derberg 04522a5
Merge pull request #1 from derberg/compile
Gmin2 8e5b6d0
Merge branch 'compile' of https://github.com/utnim2/generator into co…
Gmin2 cc0bf09
Merge branch 'master' into compile
derberg 7627f56
Update package-lock.json
derberg f37b920
Merge remote-tracking branch 'upstream/master' into compile
Gmin2 f817b42
removed `compile` from cli.js and fixed double import
Gmin2 9dbb7b7
Merge remote-tracking branch 'origin/compile' into compile
Gmin2 d98a38d
added the changeset for the release
Gmin2 5e9efbe
Update cli.js
derberg 8082c8e
Update package-lock.json
derberg 7f2af96
Update test-project.test.js
derberg 6e5cc87
Update test-registry.test.js
derberg cfda26f
making the compile option by default true
Gmin2 7123a04
Merge branch 'compile' of https://github.com/utnim2/generator into co…
Gmin2 7b3c1a9
a small test change
Gmin2 834b3cc
Update compile_option.md
derberg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,6 +46,10 @@ function conditionalFilesMatched(relativeSourceFile) { | |
return `${relativeSourceFile} was not generated because condition specified for this file in template configuration in conditionalFiles matched.`; | ||
} | ||
|
||
function compileEnabled(dir, output_dir) { | ||
return `Transpilation of files ${dir} into ${output_dir} started.`; | ||
} | ||
|
||
module.exports = { | ||
TEMPLATE_INSTALL_FLAG_MSG, | ||
TEMPLATE_INSTALL_DISK_MSG, | ||
|
@@ -59,5 +63,7 @@ module.exports = { | |
templateSuccessfullyInstalled, | ||
relativeSourceFileNotGenerated, | ||
conditionalFilesMatched, | ||
compileEnabled, | ||
compileEnabled, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. doubled export |
||
skipOverwrite | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after all works remember to remove compile flag from here as we do not enable new flags in local cli