refactor: add pacote to resolve template name instead of arborist workaround #1115
Conversation
akkshitgupta
requested review from
derberg,
magicmatatjahu,
jonaslagoni and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
derberg
changed the title
|
test/__mocks__/pacote/index.js
Outdated
| @@ -0,0 +1,9 @@ | |||
| const pacote = jest.genMockFromModule('pacote'); | |||
There was a problem hiding this comment.
tests complain
ENOENT: no such file or directory, open 'node:fs/promises'
can you have a look?
There was a problem hiding this comment.
It seems very weird to me. In my investigation, all the tests are running fine if I am not installing the pacote module and keeping all other things untouched.
When I run npm i pacote before running the tests, I get the same error. I need to figure out the possible reason.
There was a problem hiding this comment.
The node version is the culprit here: #1115 (comment)
Also, several dependencies are deprecated, which results in failing tests. The project needs to be upgraded to a newer node version with updated dependencies. I suggest updating all the project dependencies to updated versions based on our requirements.
WDYT @derberg How should we move forward?
|
@derberg @akkshitgupta Can you try deprecating the version of 
|
|
let's maybe wait for #1069 that will release new generator major release dropping support for older nodes where pacote may have issues? |
|
@akkshitgupta please solve merge conflicts |
|
Hello @derberg, after resolving conflicts, I am getting this error while running test while it was not the case before merging master. Can you have a look at here
|
|
yeah, knows issue, here is a fix #1202 |
|
@akkshitgupta you can update your PR. There is a conflict with package-lock. Just solve it locally by running npm install with verbose flag, of course after first merging latest upstream to your branch, the installation will update package-lock |
|
@akkshitgupta please have a look into failing tests |
|
|
Hey @derberg, its working now. It was an issue on the server side. on the previous update, there some network issue.test failed because of improper dependency installation. |
|
@akkshitgupta still failing |
|
Apologies for the delay @derberg. I couldn't pay much attention due to some problems. I looked into it, but couldn't find the reason. i guess, it is failing because of the template version and I don't know how tk solve it. |
|
Hey @akkshitgupta please resolve the conflicts, just change the file structure |
|
Hey @akkshitgupta your test are failing, please resolve it and feel free to ask for any help if yu need |
There was a problem hiding this comment.
@akkshitgupta you need to add pacote to package.json in apps/generator
|
@akkshitgupta you need to solve conflicts |
|
|
|
@akkshitgupta tests are failing for some strange reasons. Please consult chatgpt that gives some hints that you need to try out. Basically something related to mock and jest config |
|
@akkshitgupta do you plan to continue with this one? |
|
Apologies @derberg |
Description
pacotedependencyarbortismock and add new one forpacotegenerator.jsas suggestedRelated issue(s) fixes: #1102