Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve arborist (npm installation) to have no hacks #1102

Open
derberg opened this issue Jan 17, 2024 · 12 comments · May be fixed by #1327
Open

Improve arborist (npm installation) to have no hacks #1102

derberg opened this issue Jan 17, 2024 · 12 comments · May be fixed by #1327
Labels
area/javascript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement New feature or request good first issue Good for newcomers

Comments

@derberg
Copy link
Member

derberg commented Jan 17, 2024

use this PR as inspiration, except for:

  • no changes to workflows
  • arborist version should not be changed by this issue
  • supported engines should not be changed by this issue

What you need to do:

  • just ad pacote dependency
  • cleanup mocks and add new one - like in linked PR
  • modify generator.js as it is done in linked PR
@derberg derberg added the enhancement New feature or request label Jan 17, 2024
@derberg
Copy link
Member Author

derberg commented Jan 22, 2024

/gfi js

@asyncapi-bot asyncapi-bot added area/javascript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. good first issue Good for newcomers labels Jan 22, 2024
@AayushSaini101
Copy link
Contributor

I am on it

@derberg
Copy link
Member Author

derberg commented Jan 25, 2024

@AayushSaini101 thanks

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label May 25, 2024
@Gmin2
Copy link
Collaborator

Gmin2 commented Aug 16, 2024

As @akkshitgupta does not want to work in it anymore, i am going to take this over from the work left from #1115

@github-actions github-actions bot removed the stale label Aug 17, 2024
@derberg
Copy link
Member Author

derberg commented Aug 19, 2024

@Gmin2 awesome, I closed the other PR

@akkshitgupta thanks for initial contribution!

@ShashwatPS
Copy link

ShashwatPS commented Oct 6, 2024

Hey @derberg would like to work on this issue just wanted to clear one thing there's no dependency section in package.json so where should I mention the pacote dependency ?

@DhairyaMajmudar
Copy link
Contributor

Hey @derberg would like to work on this issue just wanted to clear one thing there's no dependency section in package.json so where should I mention the pacote dependency ?

@ShashwatPS the structure of the codebase is changed a bit (Now its following monorepo architecture) you can add mentioned dependency in generator app package.json file.

Copy link
Member Author

derberg commented Oct 21, 2024

as @DhairyaMajmudar wrote, add dependency to apps/generator

@TheMarvelFan
Copy link

@derberg

Is anyone working on this issue?

@rajRishi22
Copy link

rajRishi22 commented Nov 13, 2024

Hi @derberg , I want to work on this issue , can you please assign me this issue or should i directly raise a PR ?

Edit : I have fixed the issue , i have also updated index.md which is related to another issue in this repo can i solve both issues in the same PR?

@Gmin2
Copy link
Collaborator

Gmin2 commented Nov 14, 2024

make seperate pr for seperate issues, and we dont generally assign issues, feel free to send a PR fixing the issue !

cc @rajRishi22 @TheMarvelFan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/javascript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement New feature or request good first issue Good for newcomers
Projects
None yet
8 participants