fix problem with incorrect input

asyncapi · Sep 27, 2023 · 3dcc17a · 3dcc17a
1 parent 7b08e8d
commit 3dcc17a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/generator.js b/lib/generator.js
@@ -162,7 +162,7 @@ class Generator {
   // eslint-disable-next-line sonarjs/cognitive-complexity
   async generate(asyncapiDocument, parseOptions = {}) {
     const isAlreadyParsedDocument = isAsyncAPIDocument(asyncapiDocument);
-    const isParsableCompatible = asyncapiDocument || typeof asyncapiString === 'string';
+    const isParsableCompatible = asyncapiDocument && typeof asyncapiDocument === 'string';
     if (!isAlreadyParsedDocument && !isParsableCompatible) {
       throw new Error('Parameter "asyncapiDocument" must be a non-empty string or an already parsed AsyncAPI document.');
     }

diff --git a/test/generator.test.js b/test/generator.test.js
@@ -260,6 +260,11 @@ describe('Generator', () => {
       expect(templateConfigValidator.validateTemplateConfig).toHaveBeenCalled();
       expect(gen.launchHook).toHaveBeenCalledWith('generate:after');
     });
+
+    it('fails if input is not a string nor a parsed AsyncAPI document', async () => {
+      const gen = new Generator('testTemplate', __dirname);
+      expect(() => gen.generate(1)).rejects.toThrow('Parameter "asyncapiDocument" must be a non-empty string or an already parsed AsyncAPI document');
+    });
   });
 
   describe('#generateFromString', () => {