-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: return to top arrow feature/button #516
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for peaceful-ramanujan-288045 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
give a space after feat: and make the first letter of Return as return. it should fix the title check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anmolgupta2015 remove the changes in the package-lock json file.
Please make the arrow slightly larger IMO @anmolgupta2015 . Its not visible for a first time viewer. |
Hey @Mayaleeeee could you suggest something to @anmolgupta2015 for the design. |
Can he share a screenshot of what he is trying to do? |
@Mayaleeeee Mam Kindly let me know if you have any design idea of button or should I just make it bigger in size |
I still don't know what you are trying to do. Can you point me in the direction where I can find the changes you want to implement on the conference website? |
Hii @ashmit-coder Sir, |
Or we can have a |
Hey @Mayaleeeee does it look good to you? |
In my opinion we should have a white shadow arround the button. wdyt? cc: @Mayaleeeee @anmolgupta2015 |
Sounds great. I will implement it if you think it won't potentially distract from the main content. Do you want me to? |
This PR introduces a
ScrollToTop
button to improve user navigation across the application. The button becomes visible when the user scrolls down beyond 300px and enables smooth scrolling back to the top when clicked.Key Changes
ScrollToTop Component:
Integration in
_app.js
:ScrollToTop
component into the global_app.js
file to ensure it is available on all pages.Testing
Related Issue