Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: date/time format for online edition #483

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

anmolyadav-dev
Copy link
Contributor

This PR Fixes #482

Screenshot from 2024-11-29 22-55-10

Copy link

netlify bot commented Nov 29, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8f6a3b8
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/674af081de422900087e0b02
😎 Deploy Preview https://deploy-preview-483--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@ashmit-coder ashmit-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ashmit-coder ashmit-coder self-requested a review November 30, 2024 10:03
Copy link
Collaborator

@ashmit-coder ashmit-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the comma for helsinki date as well

config/city-lists.json Outdated Show resolved Hide resolved
@ashmit-coder
Copy link
Collaborator

cc: @anmolyadav-dev

Copy link
Collaborator

@ashmit-coder ashmit-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ashmit-coder
Copy link
Collaborator

/ptal

@asyncapi-bot
Copy link
Contributor

@AceTheCreator @thulieblack @Mayaleeeee Please take a look at this PR. Thanks! 👋

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AceTheCreator
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 4828272 into asyncapi:master Dec 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Event not marked as ended
4 participants