-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sponsor and subscribe section width on home page. #480
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for peaceful-ramanujan-288045 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @SahilDahekar could you please try and add tests for the fixes you have done in the cypress test suite. This will make sure these error dont occur in the future.
If you need help do contact me via slack.
Okay |
const eventSponsors = [ | ||
{ image: '/img/apidays.png', websiteUrl: 'https://www.apidays.global/' }, | ||
]; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @SahilDahekar could you input this urls from the json objects, so that we do not have to hard code them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should render guideline for not ended cities and agenda otherwise:
AssertionError: Timed out retrying after 4000ms: Expected to find element: `[data-test="guideline-com"]`, but never found it.
Please look into this error in the test written, its mostly due to a missing data-test
tag in the guideline component.
Below are the screenshot of the tests that were running before i made any changes to cypress e2e tests. As we can see only the Do you want me to make changes so that only the new test that is added and |
Yes @SahilDahekar the |
@SahilDahekar please make the changes as shown above |
@ashmit-coder Now ig everything is resolved and all test are passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Related issue(s)
Fixes #479