Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sponsor and subscribe section width on home page. #480

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

SahilDahekar
Copy link
Contributor

Description

  • Fixed sponsor and subscribe section width on home page.
    image

Related issue(s)

Fixes #479

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit caee986
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/67696ad460544000083b26c2
😎 Deploy Preview https://deploy-preview-480--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@ashmit-coder ashmit-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @SahilDahekar could you please try and add tests for the fixes you have done in the cypress test suite. This will make sure these error dont occur in the future.

If you need help do contact me via slack.

@SahilDahekar
Copy link
Contributor Author

Okay

const eventSponsors = [
{ image: '/img/apidays.png', websiteUrl: 'https://www.apidays.global/' },
];

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @SahilDahekar could you input this urls from the json objects, so that we do not have to hard code them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

Copy link
Collaborator

@ashmit-coder ashmit-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  should render guideline for not ended cities and agenda otherwise:
         AssertionError: Timed out retrying after 4000ms: Expected to find element: `[data-test="guideline-com"]`, but never found it.

Please look into this error in the test written, its mostly due to a missing data-test tag in the guideline component.

@SahilDahekar
Copy link
Contributor Author

  should render guideline for not ended cities and agenda otherwise:
         AssertionError: Timed out retrying after 4000ms: Expected to find element: `[data-test="guideline-com"]`, but never found it.

Please look into this error in the test written, its mostly due to a missing data-test tag in the guideline component.

Below are the screenshot of the tests that were running before i made any changes to cypress e2e tests.

Screenshot from 2024-11-27 23-50-46

Screenshot from 2024-11-27 23-50-13

As we can see only the Form should work test is running but when i made changes all the 3 tests are running.

Do you want me to make changes so that only the new test that is added and Form should work tests run ?

@ashmit-coder
Copy link
Collaborator

Yes @SahilDahekar the it.only was an bug from my side, I want you to make it to just it and as for the failed test can you tell me on which page is it failing.

@ashmit-coder
Copy link
Collaborator

        if(Date.now()>Date(city.date) && !city.ended){
            cy.getTestData("guideline-com").should("be.visible");
        }
        else{
            cy.getTestData("agenda-com").should("be.visible");
        }

@SahilDahekar please make the changes as shown above

@SahilDahekar
Copy link
Contributor Author

@ashmit-coder Now ig everything is resolved and all test are passing.

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Sponsor and Subscribe section on home page does not span full viewport width
3 participants