-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add online speaker images and names #409
Conversation
✅ Deploy Preview for peaceful-ramanujan-288045 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
hey @techmannih could you into why some of the checks are failing? |
Hey @thulieblack shall we make the images available offline, one pr is dealing with that issue. If we are adding on new images I think it should follow the same convention. |
The pr is not complete, please add the descriptions for each. |
Yes @ashmit-coder it should, please give some details on how too |
hey @thulieblack @techmannih lets wait for this issue to get resolved at first IMO. |
Makes sense, the PR isn't ready yet some of the speakers info is missing that's why checks aren't passing maybe 🤔 |
@ashmit-coder @thulieblack there is no description for rest of speakers, so how will I add |
Lets see I am not quite sure why the checks are failing as well. |
I guess @thulieblack means adding the speakers from the last years session ? |
these are passed now |
Hey @techmannih , the titles for
are missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@techmannih please make the changes
@ashmit-coder @thulieblack please check now |
@techmannih, the images are not showing Screen.Recording.2024-10-03.102400.mp4I suggest you download them, create a folder locally under |
@ashmit-coder @thulieblack please check now |
Thanks, @techmannih; I'll wait for @ashmit-coder's review first. Please be patient, reviews take time |
@thulieblack sure, thank you! |
Hey @techmannih could you try to use |
@ashmit-coder sure |
@ashmit-coder @thulieblack please check now |
LGTM! |
Hey @thulieblack ig the PR is ready to be merged! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @techmannih
/rtm |
@thulieblack please add Hacktoberfest-accepted label |
This reverts commit 6cbab41.
Close #408
Issue #408
@thulieblack please review and merge it.