fix: #356, Added hover effects to navbar and buttons #364
Conversation
SagarSharma2809
requested review from
AceTheCreator,
thulieblack and
Mayaleeeee
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for peaceful-ramanujan-288045 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @Mayaleeeee, |
|
@SagarSharma2809 your all test cases are not passing you should edit the title of your PR to small letter instead of capital one |
SagarSharma2809
changed the title
Yes, Changed the title of PR, thank you for pointing it out. |
There was a problem hiding this comment.
Looks good!
Thank you
Thoughts? @AceTheCreator @ashmit-coder @thulieblack
There was a problem hiding this comment.
@SagarSharma2809, looks good to me ❤️
Can you resolve the conflict?
Thank you! I noticed the website now has new hover effects on buttons. Would you still like to use the hover effects from my PR, or would you prefer to keep the current ones? I feel the existing ones might be more effective. Please let me know! |
|
@SagarSharma2809 thanks for your awesome contribution. I'll kindly go ahead and close this PR. Feel free to suggest other enhancements. |
Description
After:
issue.for.async.api.website.hover.effects.after.video.mp4
Related issue(s)
Fixes issue #356