fix: dropdown menu handles clicking outside #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujjwal105
requested review from
AceTheCreator,
thulieblack and
Mayaleeeee
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for peaceful-ramanujan-288045 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Mayaleeeee
approved these changes
Aug 21, 2024
ashmit-coder
pushed a commit
to ashmit-coder/conference-website
that referenced
this pull request
Sep 9, 2024
Co-authored-by: Cody's Dad <[email protected]>
ashmit-coder
added a commit
that referenced
this pull request
Nov 16, 2024
* Added cypress - Initial commit * added landing page test * added nav link tests * merge head * test * feat: update agenda times (#354) * feat: add postman logo in financial support section (#357) Co-authored-by: V Thulisile Sibanda <[email protected]>%0ACo-authored-by: asyncapi-bot <[email protected]>%0ACo-authored-by: prashantrai-30 <[email protected]> * add-ticket-link (#358) * feat: update agenda (#361) * feat: update ticket cards (#359) Co-authored-by: acethecreator <[email protected]> * feat: added the CFP form (#348) * initial commit for CFP and speakers form * changes to the form * removed comments * added example env * changes to apply btn * configured the speakers register API * changed path for CFP * url correction * added Online conference in the Navbar * Made CFP banner and details json dependent * update cfp page * Update dates * Update eventDetails.js * test commit * configured to build * temp changes to form * changes to form style * changed email message * changed the email message * changed cfp dates * changes to cfp css * changes to online page * deleted useless components * Update README.md * Update README.md * added speakers guideline component * changes to guidelines * changed carousel image * changes for production * changes to env names * testing changes * test 2 * test 3 * test 4 * test 5 * test 6 * changes to netlify.toml * test 1 * test 2 * test 3 * test 4 --------- Co-authored-by: asyncapi-bot <[email protected]> Co-authored-by: V Thulisile Sibanda <[email protected]> Co-authored-by: Ace <[email protected]> Co-authored-by: acethecreator <[email protected]> * chore(deps): bump axios from 1.6.0 to 1.7.4 (#368) * Revert "feat: update ticket cards (#359)" This reverts commit 066c265. * revert netlify * ticket update * fix-button (#369) * fix: added online cfp form (#371) * added online cfp form * testing different toml configuration * ehanced config * testing new config * fixed typo * fixed cfp date * fixed smtp pass typo (#372) * fix issue #356 (#374) * Dropdown bug fixed (#353) Co-authored-by: Cody's Dad <[email protected]> * feat: update speakers.json (#383) * Merge master * package lock changes * changes to package lock * fix bug in home * added navbar mobile tests * added base venue tests * added cfp test * package-lock changes * added cypress test * changes to setup versions * changes to regex * test commit --------- Co-authored-by: V Thulisile Sibanda <[email protected]> Co-authored-by: prashantrai-30 <[email protected]> Co-authored-by: V Thulisile Sibanda <[email protected]>%0ACo-authored-by: asyncapi-bot <[email protected]>%0ACo-authored-by: prashantrai-30 <[email protected]> Co-authored-by: acethecreator <[email protected]> Co-authored-by: asyncapi-bot <[email protected]> Co-authored-by: Ace <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Saurbh Kumar <[email protected]> Co-authored-by: Ujjwal Tyagi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When tapping anywhere outside the dropdown menu after it has been opened, the dropdown should close.
Related issue(s)
Fixes #352