Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clicking on address navigates you to the google maps #271

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

helios2003
Copy link
Contributor

@helios2003 helios2003 commented Mar 12, 2024

Description
On clicking on the address in the Venue page, it takes you to the location on Google maps.
Related issue(s)
Fixes #270

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit 6ca088a
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/65f48022e9bdeb0008254af0
😎 Deploy Preview https://deploy-preview-271--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@helios2003 helios2003 changed the title clicking on address navigates you to the google maps fix: clicking on address navigates you to the google maps Mar 12, 2024
@AceTheCreator
Copy link
Member

@helios2003, thanks for the amazing contribution!

Can you underline the address on hover?

@helios2003
Copy link
Contributor Author

Sure, will do it.

@AceTheCreator
Copy link
Member

LGTM!!!

@AceTheCreator AceTheCreator merged commit c260e82 into asyncapi:master Mar 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to location on map
2 participants