Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added a mapsection on each venue page #206

Closed
wants to merge 2 commits into from

Conversation

kabszac
Copy link

@kabszac kabszac commented Sep 29, 2023

Description

  • Added a map section on each venue page
  • I used leaflet and react - leaflet

Related issue(s)
fixes #165

Screenshot from 2023-09-30 00-46-35

Screenshot from 2023-09-30 00-46-41

@netlify
Copy link

netlify bot commented Sep 29, 2023

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit 7423734
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/651ff6def5be6e00076864cd
😎 Deploy Preview https://deploy-preview-206--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kabszac
Copy link
Author

kabszac commented Sep 29, 2023

@AceTheCreator made a new pull request kindly review.

@AceTheCreator
Copy link
Member

@AceTheCreator made a new pull request kindly review.

LGTM!

@AceTheCreator
Copy link
Member

@Mayaleeeee wyt?

@Mayaleeeee
Copy link
Member

@Mayaleeeee wyt?

Looks good, thanks @kabszac.

Here are my observations @kabszac :

  1. The colour you used for the card is dark, compared to the one I used; please kindly use the one in the image I sent below.
  2. The spacing between the location is too much as well, please kindly reduce it and make them both aligned in the center.
    Screenshot 2023-10-05 115318
    cc @AceTheCreator

Below is the image for reference
Map

@kabszac
Copy link
Author

kabszac commented Oct 6, 2023

@Mayaleeeee made the changes.

@AceTheCreator
Copy link
Member

@Mayaleeeee made the changes.

cc @Mayaleeeee

@Mayaleeeee
Copy link
Member

@Mayaleeeee made the changes.

cc @Mayaleeeee

Thanks @kabszac @AceTheCreator

I can only see this on my phone, and I'm not sure why the location pointer is white. Additionally, I couldn't find the card that displays the description.

Regardless, I'll take another look when I'm on my laptop.

Screenshots_2023-10-09-19-13-51.png

@Mayaleeeee
Copy link
Member

@Mayaleeeee made the changes.

cc @Mayaleeeee

@kabszac, thank you for working on this; here are my reviews on the design.

  1. The location pointer need not be clicked to view the placeholder. The purpose of the placeholder is to provide the user with a glance at the location and date. Therefore, there is no need for any interaction with the card, as seen in the recording below.
    23082528-6867-4f0a-8dd0-7c0ed2521392.webm

  2. The location icon on the card is too small compared to the calendar icon. I used 20px for the icons and 16px for the texts.
    Screenshot 2023-10-11 022115

  3. Instead of being placed outside, The 'X' close icon should be positioned inside the card at the top with a white colour. The expected design is shown in the image below. When the user clicks on the 'X' icon, it should close the card, and the card should reopen when the user clicks on the location pointer.

Screenshot 2023-10-11 024410

Copy link

github-actions bot commented Feb 9, 2024

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Feb 9, 2024
@thulieblack
Copy link
Member

Website has been updated to 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include a map section on each venue page
4 participants