Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed apply as a speaker button in Paris Conference page #197

Merged
merged 6 commits into from
Sep 25, 2023

Conversation

ankur0904
Copy link
Contributor

Description

Fixed the Apply as a Speaker button to work as expected.

Related issue(s)
Fixes #179

cc @AceTheCreator @thulieblack

@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit e042829
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/650ddc7c560ecc0008ad06b9
😎 Deploy Preview https://deploy-preview-197--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AceTheCreator
Copy link
Member

@ankur0904, the link should only be applied for Paris(it also includes Bangalore). It should also be included in the venue section :)

@thulieblack
Copy link
Member

The Apply button is not working from my end

screen-capture.webm

@ankur0904
Copy link
Contributor Author

@AceTheCreator @thulieblack Made the required changes.

@thulieblack
Copy link
Member

console.log shouldn't be visible

image

@ankur0904
Copy link
Contributor Author

@thulieblack Removed console.log

@thulieblack
Copy link
Member

Perfect, I will merge this next week together #184

@AceTheCreator
Copy link
Member

@ankur0904 the apply button under the venue page(Paris) not working https://deploy-preview-192--peaceful-ramanujan-288045.netlify.app/venue/paris

@ankur0904
Copy link
Contributor Author

@AceTheCreator
Hi, I think it was old one. The latest preview is working. Please have a look https://deploy-preview-197--peaceful-ramanujan-288045.netlify.app/venue/paris

@AceTheCreator
Copy link
Member

@ankur0904 I'd advise you to make the link open on a new tab since it's an external link

@ankur0904
Copy link
Contributor Author

@AceTheCreator Done :)

@AceTheCreator
Copy link
Member

@ankur0904 you have some build error :)

@ankur0904
Copy link
Contributor Author

@AceTheCreator Fixed :)

@AceTheCreator AceTheCreator merged commit fa25c2d into asyncapi:master Sep 25, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paris Conference - Apply as a Speaker don't work
3 participants