-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: get ticket button added #186
Conversation
✅ Deploy Preview for peaceful-ramanujan-288045 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@vishvamsinh28 I don't see an issue opened for this pr; we're also following the design provided by @Mayaleeeee @Mayaleeeee wyt? |
@AceTheCreator I have opened issue for this #186 . And @derberg wanted button for buying tickets on the venue page also |
It makes sense, @AceTheCreator. The button has to be there because we want to make it easy for our users to buy tickets for each location without returning to the main landing page. So, a big thank you to @derberg and @vishvamsinh28 for their contribution. @vishvamsinh28, let me explain how it's supposed to work. We need to remove the ''Agenda, Speakers, and Event & Host Sponsor'' button. Please watch the video below for a visual reference on how it should look and how the button should interact. |
@Mayaleeeee @AceTheCreator removed buttons and updated design of ticket button |
@Mayaleeeee WYT? |
@vishvamsinh28, please could you add another Free Tickets Form button on the London page. here's the link 👉🏿 https://forms.gle/c7t8k2JABcF26guq5 thank you so much |
Let's use our pry colour as suggested by @thulieblack. |
@AceTheCreator Is the distance between the location and date intentional? I would like to know before creating issues on it. |
@vishvamsinh28, you made a mistake on the London Page. There need to be two buttons:
|
@thulieblack buttons and links are updated |
config/city-lists.json
Outdated
"ticket": "https://opencollective.com/asyncapi/events/asyncapi-conference-on-tour-6b3c0aa1/contribute/aacot-london-edition-61313", | ||
"freeTicket":"https://docs.google.com/forms/d/e/1FAIpQLSdKxKvHGqmCmFJ7ldJJcAJNnmuie057vYrEh219gCXRDMZU5g/viewform", | ||
"buttonText":"Get your Tickets", | ||
"freeTicketTxt":"Tickets Form" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"freeTicketTxt":"Tickets Form" | |
"freeTicketTxt":"Free Tickets Form" |
Hey @thulieblack
|
@Mayaleeeee, it is correct the way it is. We have two different buttons for 2 different tickets We have a paid ticket option and a free ticket option that's why the form is there |
@thulieblack Primary buttons are used to represent the most important action on a page, so what I am saying in essence is that, one has to be a pry button, and the other a secondary. We need to prioritize the one we want our users to click on, then that would be our pry button. Also, if the ticket form is for free tickets, then I suggest we change it to free tickets, because the ticket form sounds confusing. @thulieblack |
@Mayaleeeee, do you have suggestions on what we should do because they both need to be there on the page? |
Yeah, I do. @thulieblack Which one is our main priority? If it's the first one, then that would be our primary button, and the second would be a secondary. |
Prioritize Get your Tickets following Free Tickets Form |
@Mayaleeeee How it should look on the website ? |
I'm gonna design that, and show you. Thank you @thulieblack @vishvamsinh28 |
@thulieblack, So here are my suggestions
In essence, I am saying that if the "Ticket Form" button is for free tickets, then let it be explicitly mentioned to avoid confusion and misunderstandings. |
Hey Maya, I like the design; let's go ahead with it. @vishvamsinh28 These changes only apply to the London page only. The Madrid page is fine as it is. You can also change the button description to "Grab Free Tickets" as Maya suggests. The form will be visible on the website until the 17th of September so it is only for a week that it needs to be there. Thanks |
Hey @vishvamsinh28 do not add the free ticket button anymore . Just remove it whenever you get a chance and lets get it merged |
@thulieblack we can merge this pr now i have made changes |
hey @vishvamsinh28 we're almost there a few things
Let me know if I can clear up any confusion or need any help |
Thanks so much @AceTheCreator please merge this |
added button on venue page to buy ticket
fixes #185