Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: how to become tsc member #449

Merged
merged 69 commits into from
Nov 7, 2022
Merged

Conversation

Dindihub
Copy link
Contributor

Description
resolves #809. A summary of YT video on how to become a tsc member of asyncapi

  • ...
  • ...
  • ...

Related issue(s)

@Dindihub
Copy link
Contributor Author

Hi @derberg. I made a summary of the YT video on TSC membership. Let me know what you think. Thanks

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can't imagine how happy I am for you doing this PR ❤️

thanks so much 🙇🏼 I left few comments to improve the doc

TSC_MEMBERSHIP.md Outdated Show resolved Hide resolved
TSC_MEMBERSHIP.md Outdated Show resolved Hide resolved
TSC_MEMBERSHIP.md Outdated Show resolved Hide resolved
TSC_MEMBERSHIP.md Outdated Show resolved Hide resolved
TSC_MEMBERSHIP.md Outdated Show resolved Hide resolved
TSC_MEMBERSHIP.md Outdated Show resolved Hide resolved
TSC_MEMBERSHIP.md Outdated Show resolved Hide resolved
TSC_MEMBERSHIP.md Outdated Show resolved Hide resolved
TSC_MEMBERSHIP.md Outdated Show resolved Hide resolved
TSC_MEMBERSHIP.md Outdated Show resolved Hide resolved
@derberg derberg changed the title docs: how to become tsc member(asyncapi#809) docs: how to become tsc member Aug 29, 2022
Dindihub and others added 12 commits August 30, 2022 10:06
Co-authored-by: Lukasz Gornicki <[email protected]>
Co-authored-by: Lukasz Gornicki <[email protected]>
Co-authored-by: Lukasz Gornicki <[email protected]>
Co-authored-by: Lukasz Gornicki <[email protected]>
Co-authored-by: Lukasz Gornicki <[email protected]>
Co-authored-by: Lukasz Gornicki <[email protected]>
Co-authored-by: Lukasz Gornicki <[email protected]>
Co-authored-by: Lukasz Gornicki <[email protected]>
Co-authored-by: Lukasz Gornicki <[email protected]>
Co-authored-by: Lukasz Gornicki <[email protected]>
Co-authored-by: Lukasz Gornicki <[email protected]>
Co-authored-by: Lukasz Gornicki <[email protected]>
Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just saw one tiny commit suggestion fix but wondering if you think this is good now, @derberg? 😬✌🏽

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one tiny thing to add, thanks!

TSC_MEMBERSHIP.md Outdated Show resolved Hide resolved
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Dindihub thanks a 100 for all your work and patience 🙇🏼

@Dindihub
Copy link
Contributor Author

rocket

@Dindihub thanks a 100 for all your work and patience 🙇🏼

My pleasure @derberg

@quetzalliwrites
Copy link
Member

thank you SO much for your patience and for your lovely work @Dindihub! 🙌🏾✨✨✨

I will let @derberg decide when to merge it ✌🏽

@derberg
Copy link
Member

derberg commented Nov 7, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 7991c12 into asyncapi:master Nov 7, 2022
@derberg
Copy link
Member

derberg commented Nov 7, 2022

@all-contributors please add @Dindihub for docs

@allcontributors
Copy link
Contributor

@derberg

I've put up a pull request to add @Dindihub! 🎉

@derberg
Copy link
Member

derberg commented Nov 7, 2022

@Dindihub I just discovered after merge that there is a bug, wrong link is provided.

We have 2 links like

[Become a maintainer in an existing project](https://github.com/asyncapi/community/pull/449/files#diff-2ac814c110d5ccfbf064b21de6aa22f6a5a63f00eaf1107282c2c13a4a9562df)

that should actually look like

[Become a maintainer in an existing project](Become-maintainer-in-existing-project.md)

wanna open up a followup PR?

@derberg
Copy link
Member

derberg commented Nov 7, 2022

ups actually, there is a bigger issue :) these links are provided in wrong place.
It should be just one link under bullet point Support and commit to existing projects and be invited by other maintainers to join them as a maintainer

@Dindihub
Copy link
Contributor Author

Dindihub commented Nov 8, 2022

ups actually, there is a bigger issue :) these links are provided in wrong place. It should be just one link under bullet point Support and commit to existing projects and be invited by other maintainers to join them as a maintainer

Hi @derberg, can you reopen the PR so I can make the changes?

Copy link
Member

derberg commented Nov 8, 2022

@Dindihub it doesn't work this way, it would have to be another PR. You need to update your fork with latest upstream master, create new branch and make changes

@Dindihub
Copy link
Contributor Author

@Dindihub it doesn't work this way, it would have to be another PR. You need to update your fork with latest upstream master, create new branch and make changes

OH! Noted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. 📑 docs ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants