ci: add workflows to automate merging of human-actor created PRs #125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes asyncapi/.github#31
Why we need it
AsyncAPI GH org changes
Once we are happy with the proposed workflows, this is what will change in the GH org settings:
outside collaborators
but will havewrite
access on "their" repos individuallyChange in how maintainers work
You can still work as before
**BUT IT DOESN'T MAKE SENSE 😆 **
write
level access to the given repo otherwise CODEOWNERS do not work 😞Still, I recommend below!
Lukasz's recommended way of working
You are happy with PR, all checks passed? you already approved? DON'T merge manually:
Just add
/ready-to-merge
or/rtm
comment (can be multiline as in example below)ready-to-merge
label will be addedautomerge for humans
workflow will trigger (it triggers also because of other events)What is missing here
Docs and education. No workflow that would put info on PR about the special comment that people can use. Simple because let us first use it for a couple of weeks to make sure all works well.
Proof workflows work
Test PR that proves that PR is labeled only when a proper comment is done. You can also see there merging was done, it looks like it is me but only because auto-merge bot in my tests use my token: