-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding initial Community Growth WG proposal #1090
Closed
Closed
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a90a491
adding initial the Community Growth WG proposal
Barbanio 7150d9e
grammar fixes
quetzalliwrites 6e46602
Merge branch 'master' into community_growth_wg
thulieblack 29680c3
Merge remote-tracking branch 'asyncapi/master' into community_growth_wg
Barbanio 211847d
Added to Thulie
Barbanio c8e5c0c
Adding to Maya
Barbanio ccf9919
Merge branch 'master' into community_growth_wg
quetzalliwrites File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shurtu-gal gave me feedback coming from #1072 regarding the fact there are no Slack handles in this file. That will complicate automation of Slack channels and aliases creation since we do not have a real database of GH User -> Slack Handle (or vice-versa).
Do you believe we should add somehow those Slack handles here as well? I do, but not sure how 🤔
Ideas? cc @derberg @fmvilas (who iirc were involved in the initial creation of the structure of this file)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure thing, if technically it makes sense then extend the yaml with proper info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm.. I can certainly see the value in adding our Slack handles, given the asynchronous nature of our work and Slack is our primary communication method. 😸
Is it as simple to add them manually to this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe something like this could be ok?
I noticed we need those single quotes I added because otherwise the YAML is invalid (strings can't start by
@
, another solution could be just removing the@
character as in https://github.com/asyncapi/community/blob/master/MAINTAINERS.yaml). BTW, emails are invented. Names are added exactly as in Slack profiles so feel free to change yours if you don't want to appear like that.EDIT: Added the email but not sure if really required. I thought about adding it just in case we need to create meetings or email members at some point. But of course we can't create @asyncapi.com emails for everyone, so maybe just using personal email and make it optional? Nevermind, we can skip the
email
by now until we find is fully required (if happens).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we add slack IDs instead of names similar to how we have it in https://github.com/asyncapi/community/blob/master/TSC_MEMBERS.json ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooooh, good question by Thulie... I am curious if she is correct in suggesting we use slack IDs instead!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah good point. Ids are consistent. Using names will be fragile because what if you change your display name!
So yes, we should do change it and use IDs instead.
Nice catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only needed IDs ( these are local to the org workspace anyway ). Thanks @thulieblack .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Once this is solved (deciding on the chairperson), I will update this PR (or create a new one, will see) with the changes