-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix of CODEOWNERS files #275
Comments
Contributes to: asyncapi/community#275 Signed-off-by: Dale Lane <[email protected]>
Contributes to: asyncapi/community#275 Signed-off-by: Dale Lane <[email protected]>
Contributes to: asyncapi/community#275 Signed-off-by: Dale Lane <[email protected]>
I postpone merge of asyncapi/.github#139 till evening as CI is pretty heavily occupied today, and I was not able to merge it in the morning due to other issues -> https://asyncapi.slack.com/archives/C01J06RL10X/p1646217113770569 |
the CODEOWNERS file where @github-actions[bot] was being added as Code Owner. This is not currently possible, as we noticed recently thanks to GH which added lining to the CODEOWNERS file. Instead, @asyncapi-bot-eve user has been created for this purpose and now is being added into the CODEOWNERS file. Refer asyncapi/community#275
the CODEOWNERS file where @github-actions[bot] was being added as Code Owner. This is not currently possible, as we noticed recently thanks to GH which added lining to the CODEOWNERS file. Instead, @asyncapi-bot-eve user has been created for this purpose and now is being added into the CODEOWNERS file. Refer asyncapi/community#275
There will be now a bunch of PR created to update workflows with new bot. They will not be automatically merged and we also had to rename some jobs (thus branch protection is now misconfigured....). I'm on it |
@tsc_members looks like topic closed.
Remember, side effect is that now finally CODEOWNERS will work as expected. This means GitHub will automatically assign code owners as reviewers to PRs where files that they own are modified. If there is something you do not like with how it works, you need to optimize setup in CODEOWNERS in your repo |
@asyncapi/tsc_members we need your action as soon as possible. But only if you have
CODEOWNERS
file in repos that you maintain (which is like 98% 😆 )asyncapi-bot-eve
CODEOWNERS
files in your repos by replacing@github-actions[bot]
with@asyncapi-bot-eve
(this bot already have all necessary rights)Unfortunately, there is no way to: "we do it first and then you do it and all will work".
I will merge asyncapi/.github#139 tomorrow, and you just please fix CODEOWNERS as soon as you can, otherwise, automated PRs in your repos will not work, won't be automerged
The text was updated successfully, but these errors were encountered: