Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of CODEOWNERS files #275

Closed
derberg opened this issue Mar 1, 2022 · 3 comments
Closed

Fix of CODEOWNERS files #275

derberg opened this issue Mar 1, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@derberg
Copy link
Member

derberg commented Mar 1, 2022

@asyncapi/tsc_members we need your action as soon as possible. But only if you have CODEOWNERS file in repos that you maintain (which is like 98% 😆 )

  • Once we merge ci: use custom bot to approve automated PRs .github#139
  • All automated PRs will be accepted by new asyncapi-bot-eve
  • But these PRs will not be automatically merged. Because only CODEOWNERS approvals matters
  • Your Action You need to update CODEOWNERS files in your repos by replacing @github-actions[bot] with @asyncapi-bot-eve (this bot already have all necessary rights)

Unfortunately, there is no way to: "we do it first and then you do it and all will work".
I will merge asyncapi/.github#139 tomorrow, and you just please fix CODEOWNERS as soon as you can, otherwise, automated PRs in your repos will not work, won't be automerged

NOTE
A positive side effect is that by fixing CODEOWNERS with new bot all suddenly a missing feature will work -> automated assignment of codeowners to pull requests 💪🏼

@derberg derberg added the enhancement New feature or request label Mar 1, 2022
dalelane added a commit to dalelane/bindings that referenced this issue Mar 1, 2022
Contributes to: asyncapi/community#275

Signed-off-by: Dale Lane <[email protected]>
dalelane added a commit to asyncapi/bindings that referenced this issue Mar 1, 2022
smoya added a commit to smoya/event-gateway that referenced this issue Mar 1, 2022
smoya added a commit to smoya/event-gateway that referenced this issue Mar 1, 2022
dalelane added a commit to asyncapi/java-template that referenced this issue Mar 1, 2022
smoya added a commit to smoya/converter-go that referenced this issue Mar 1, 2022
smoya added a commit to smoya/parser-api that referenced this issue Mar 1, 2022
smoya added a commit to smoya/server-api that referenced this issue Mar 1, 2022
smoya added a commit to asyncapi/template-for-go-projects that referenced this issue Mar 1, 2022
@derberg
Copy link
Member Author

derberg commented Mar 2, 2022

I postpone merge of asyncapi/.github#139 till evening as CI is pretty heavily occupied today, and I was not able to merge it in the morning due to other issues -> https://asyncapi.slack.com/archives/C01J06RL10X/p1646217113770569

M3lkior added a commit to asyncapi/avro-schema-parser that referenced this issue Mar 2, 2022
the CODEOWNERS file where @github-actions[bot] was being added as Code Owner. This is not currently possible, as we noticed recently thanks to GH which added lining to the CODEOWNERS file.
Instead, @asyncapi-bot-eve user has been created for this purpose and now is being added into the CODEOWNERS file.

Refer asyncapi/community#275
dalelane pushed a commit to asyncapi/avro-schema-parser that referenced this issue Mar 2, 2022
the CODEOWNERS file where @github-actions[bot] was being added as Code Owner. This is not currently possible, as we noticed recently thanks to GH which added lining to the CODEOWNERS file.
Instead, @asyncapi-bot-eve user has been created for this purpose and now is being added into the CODEOWNERS file.

Refer asyncapi/community#275
@derberg
Copy link
Member Author

derberg commented Mar 3, 2022

There will be now a bunch of PR created to update workflows with new bot. They will not be automatically merged and we also had to rename some jobs (thus branch protection is now misconfigured....). I'm on it

@derberg
Copy link
Member Author

derberg commented Mar 3, 2022

@tsc_members looks like topic closed.

  • workflows are update
  • CODEOWNERS are updated in 55 repos, owners of remaining 4 got notified
  • there should be no disruption on PR level now, no long hanging CI check

Remember, side effect is that now finally CODEOWNERS will work as expected. This means GitHub will automatically assign code owners as reviewers to PRs where files that they own are modified.

If there is something you do not like with how it works, you need to optimize setup in CODEOWNERS in your repo

@derberg derberg closed this as completed Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant