Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve glee default template #946

Merged
merged 11 commits into from
Apr 18, 2024
Merged

fix: improve glee default template #946

merged 11 commits into from
Apr 18, 2024

Conversation

KhudaDad414
Copy link
Member

@KhudaDad414 KhudaDad414 commented Dec 1, 2023 •
edited
Loading

Description
This PR will introduce the following improvements:

  • upgrade the template to v3.
  • improve it's docs.

@KhudaDad414 KhudaDad414 marked this pull request as draft December 1, 2023 11:46
@KhudaDad414 KhudaDad414 mentioned this pull request Dec 1, 2023
Merged
@KhudaDad414 KhudaDad414 marked this pull request as ready for review December 1, 2023 20:30
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Mar 31, 2024
@github-actions github-actions bot removed the stale label Apr 3, 2024
derberg
derberg previously approved these changes Apr 10, 2024
View reviewed changes
@derberg
Copy link
Member

derberg commented Apr 10, 2024

@KhudaDad414 is it even still needed?

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@KhudaDad414
Copy link
Member Author

KhudaDad414 commented Apr 17, 2024 •
edited
Loading

@KhudaDad414 is it even still needed?

yes. the default example doesn't work without these changes.

@derberg
Copy link
Member

derberg commented Apr 18, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit f5f281e into asyncapi:master Apr 18, 2024
11 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.8.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@KhudaDad414 KhudaDad414 deleted the fix-glee-default branch April 18, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg approved these changes

@Souvikns Souvikns Awaiting requested review from Souvikns Souvikns is a code owner

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KhudaDad414 @derberg @asyncapi-bot @Souvikns