-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: patch spectral cli to remove vm2 #750
fix: patch spectral cli to remove vm2 #750
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
@mattias-persson for some reason all the tests are failing. |
Yes, I would need your input on why if you get a chance @Souvikns... 😅 |
Something is wrong with the @magicmatatjahu need your help here. |
Co-authored-by: Lukasz Gornicki <[email protected]>
@mattias-persson hey, you need to solve some conflicts. Once you do it, please ping me through a comment. I do not get notifications from GH that some new commits were in the PR, so I don't know it is a time for followup review. Thanks 🙏🏼 btw, I changed to |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Alright @derberg, should be resolved now. Let me know if you see anything funky! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
/rtm |
🎉 This PR is included in version 0.56.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
src/parser.ts
Related issue(s)
See also #727 and stoplightio/spectral#2510.