fix: make sure that cli commands generation builds project #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derberg
requested review from
Souvikns,
magicmatatjahu,
boyney123 and
asyncapi-bot-eve
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
Souvikns
approved these changes
May 31, 2023
|
/rtm |
|
🎉 This PR is included in version 0.45.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #123 (comment)
all work done by @mhmohona was great, we just forgot that by config it is looking for commands in
/home/runner/work/cli/cli/lib/commandsbutlibis a folder that is not in repo, it needs to be build withnpm run buildmaking it as fix as also recent release was broken because of it we assets were not uploaded