fix: issue with prepack command that blocks release #252
Conversation
Souvikns
requested review from
magicmatatjahu,
derberg,
boyney123 and
asyncapi-bot-eve
as code owners
package.json
Outdated
| @@ -131,7 +131,7 @@ | |||
| "lint": "eslint --max-warnings 0 --config .eslintrc .", | |||
| "lint:fix": "eslint --max-warnings 5 --config .eslintrc . --fix", | |||
| "postpack": "rimraf oclif.manifest.json", | |||
| "prepack": "rimraf lib && tsc -b && oclif manifest && oclif readme", | |||
| "prepack": "npm run build && oclif manifest && oclif readme", | |||
| "prepublishOnly": "npm run build", | |||
There was a problem hiding this comment.
do we need this if we build it in prepack stage?
There was a problem hiding this comment.
Yeah since we are building in prepublish stage which is run before prepack we don't need this. Though we are also running oclif readme in version so we might now need that too
Line 140 in 9fecc14
also I think this is why the TOC is not working
There was a problem hiding this comment.
imho:
- we should only have
prepublishOnlythat runs:npm run build && oclif manifest versionscript is not needed, can be removed, sameprepack. Same withreadmescript I guessoclif readmeshould be added togenerate:assets. Although I do not really know whatoclif readmeis actually doing 😆 But if it is doing some important update to readme, it should be ingenerate:assetsscript. This workflow will make sure readme is updated in GH repo. We can also rungenerate:assetsinprepublishOnlyscript if we need also some magic updates in readme to show up in NPM package readme view
makes sense?
There was a problem hiding this comment.
I have removed oclif readme. It creates documentation which is handled here #123
|
Kudos, SonarCloud Quality Gate passed!
|
derberg
changed the title
|
I have deleted the |
|
/rtm |
|
🎉 This PR is included in version 0.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Trying to fix the issue with
npm prepackcommand holding of the gh action and not able to publish.Still now clear what is causing the issue, since not much log is present, as of now two action run has failed for this
I tried running the command separately on my fork and it ran not sure why it is having issues here - https://github.com/Souvikns/cli/runs/5469720664?check_suite_focus=true