Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw error on unhandled rejections node < 15 #238

Merged
merged 6 commits into from
Apr 20, 2022
Merged

fix: throw error on unhandled rejections node < 15 #238

merged 6 commits into from
Apr 20, 2022

Conversation

imabp
Copy link
Member

@imabp imabp commented Feb 21, 2022

Description

  • For NodeJS < 15, unhandled rejections are treated as warnings. This is required for consistency in error handling.

Related issue(s)
#234

cc: @magicmatatjahu

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@imabp
Copy link
Member Author

imabp commented Mar 6, 2022

@Souvikns diff tests are failing somehow only on mac os.

@magicmatatjahu
Copy link
Member

@imabp I rerun the jobs, it was a temp error, it happens :)

@imabp
Copy link
Member Author

imabp commented Mar 7, 2022

Feel free to merge it @magicmatatjahu , if you feel its right, and nothing to add much.

Copy link
Member

@Souvikns Souvikns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derberg
Copy link
Member

derberg commented Apr 20, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 2939adf into asyncapi:master Apr 20, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.18.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants