Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate to latest oclif version #203

Merged
merged 13 commits into from
Mar 2, 2022
Merged

feat: migrate to latest oclif version #203

merged 13 commits into from
Mar 2, 2022

Conversation

Souvikns
Copy link
Member

Description
This PR aims to migrate to the new oclif version and also remove other unnecessary packages, and follow the new doc by oclif.

Related issue(s)

See also #192

@Souvikns Souvikns mentioned this pull request Jan 31, 2022
Closed
@Souvikns Souvikns marked this pull request as ready for review January 31, 2022 12:50
@Souvikns Souvikns mentioned this pull request Feb 4, 2022
Merged
@Souvikns
Copy link
Member Author

Souvikns commented Feb 7, 2022

I modeled my PR based on the current boilerplate that oclif generates when we create a new project. packages like @oclif/command, @oclif/config have been merged into @oclf/core. Functionality did not change much just needed to update the imports and that's all.

Some things changed like

@magicmatatjahu
Copy link
Member

@Souvikns Do you want to wait for feedback in oclif/core#360 issue? Also I wonder if we should go with chore: prefix because if we merge it and then try to merge another PRs we won't that help support, so I guess that we will have inconsistent in the code, right? Sorry I'm not up to date with CLI code, so I don't know.

@Souvikns
Copy link
Member Author

Souvikns commented Feb 7, 2022 •
edited
Loading

@Souvikns Do you want to wait for feedback in oclif/core#360 issue? Also I wonder if we should go with chore: prefix because if we merge it and then try to merge another PRs we won't that help support, so I guess that we will have inconsistent in the code, right? Sorry I'm not up to date with CLI code, so I don't know.

I do want to wait for the reply but then again the CLI is showing warnings in production I am kinda confused on what should we do here.

Also topic help works but the command is slightly changed
Before
asyncapi start would show the topic level help
Now
needs asyncapi start --help to show help

@magicmatatjahu
Copy link
Member

@Souvikns Sorry for that delayed response.

Hmmm 🤔 Ok, I understand. However, I have still that afraid with merging it, because we have a lot opened PRs and even if we merge it as chore: and then try to fix problems as fast as possible, other people will have to wait for us. cc @derberg

@Souvikns
Copy link
Member Author

Souvikns commented Feb 9, 2022

Maybe we wait and let others finish and then merge it, that way we don't block anyone.

@Souvikns
Copy link
Member Author

@magicmatatjahu found a way to show command help for topics all thanks to oclif/core#360 Now everything works like before.

@magicmatatjahu
Copy link
Member

@Souvikns

Maybe we wait and let others finish and then merge it, that way we don't block anyone.

I prefer that option. Of course we should wait only for some PRs, not for everyone, that PRs which is very close to merge :)

found a way to show command help for topics all thanks to oclif/core#360 Now everything works like before.

Awesome!

@Souvikns Souvikns mentioned this pull request Feb 21, 2022
Closed
@Souvikns Souvikns mentioned this pull request Feb 23, 2022
Closed
@Souvikns
Copy link
Member Author

@magicmatatjahu shall we merge this, #244 I think people are having issues. I can help all other PR's with the changes that they might need to do.

@magicmatatjahu
Copy link
Member

@Souvikns I checked your changes locally and CLI works as expected :) However if we merge it we need focus on fixing problems and release new version in a short time. I can help with opened PRs, but without a release some issues will not be fixed.

@derberg What do you think?

@magicmatatjahu
Copy link
Member

@Souvikns Could we merge it as feat:? I've already forgotten, but what's stopping us from releasing the new version?

@Souvikns
Copy link
Member Author

Souvikns commented Mar 2, 2022

Once we merge this all other open PRs will have conflict, nothing other than that.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derberg
Copy link
Member

derberg commented Mar 2, 2022

we need to release it, not just merge. I recommend feat: prefix

@magicmatatjahu
Copy link
Member

magicmatatjahu commented Mar 2, 2022 •
edited
Loading

@Souvikns

Once we merge this all other open PRs will have conflict, nothing other than that.

But we can help people to fix their PRs, this's not problem :)

@Souvikns Souvikns changed the title chore: migrate to latest oclif version feat: migrate to latest oclif version Mar 2, 2022
@derberg
Copy link
Member

derberg commented Mar 2, 2022

@magicmatatjahu did you review it already? do I have to look at something?

@magicmatatjahu
Copy link
Member

@derberg I checked it locally and it works :) We can merge it.

@derberg
Copy link
Member

derberg commented Mar 2, 2022

@magicmatatjahu then why didn't you approve it? 😆

magicmatatjahu
magicmatatjahu approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derberg I'm waiting for you to make a move 😆

@Souvikns Awesome work! We should add info the slack that we merge that PR and people should fix their PRs, of course we can help them.

@derberg
Copy link
Member

derberg commented Mar 2, 2022

@Souvikns
Copy link
Member Author

Souvikns commented Mar 2, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 33d0eb5 into asyncapi:master Mar 2, 2022
This was referenced Mar 7, 2022
Closed
Merged
Souvikns added a commit to Souvikns/cli that referenced this pull request Mar 8, 2022
@Souvikns @imabp
@derberg @magicmatatjahu @asyncapi-bot @allcontributors @Samridhi-98
Prepack fix (#1)
994e294 
* docs: fix missing toc (asyncapi#230)

* feat: add global specification watcher (asyncapi#220)

Co-authored-by: Lukasz Gornicki <[email protected]>
Co-authored-by: Maciej Urbańczyk <[email protected]>

* chore(release): v0.14.0 (asyncapi#237)

* docs: add imabp as a contributor for code (asyncapi#239)

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* fix: update @asyncapi/studio to 0.10.0 version (asyncapi#241)

* chore(release): v0.14.1 (asyncapi#242)

* feat: added testing for new (asyncapi#212)

* docs: add Samridhi-98 as a contributor for test (asyncapi#248)

* ci: update global workflows (asyncapi#246)

* chore(release): v0.15.0 (asyncapi#249)

* feat: migrate to latest oclif version (asyncapi#203)

* chore: update bot name from codeowners file (asyncapi#247)

* ci: update global workflows (asyncapi#250)

* Create test.yml

* Update test.yml

* Update test.yml

* Update test.yml

* Update test.yml

Co-authored-by: Abir <[email protected]>
Co-authored-by: Lukasz Gornicki <[email protected]>
Co-authored-by: Maciej Urbańczyk <[email protected]>
Co-authored-by: asyncapi-bot <[email protected]>
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Samriddhi <[email protected]>
Co-authored-by: asyncapi-bot <[email protected]>
Souvikns added a commit to Souvikns/cli that referenced this pull request Mar 8, 2022
@Souvikns @imabp
@derberg @magicmatatjahu @asyncapi-bot @allcontributors @Samridhi-98
Prepack fix (#2)
bfc3505 
* docs: fix missing toc (asyncapi#230)

* feat: add global specification watcher (asyncapi#220)

Co-authored-by: Lukasz Gornicki <[email protected]>
Co-authored-by: Maciej Urbańczyk <[email protected]>

* chore(release): v0.14.0 (asyncapi#237)

* docs: add imabp as a contributor for code (asyncapi#239)

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* fix: update @asyncapi/studio to 0.10.0 version (asyncapi#241)

* chore(release): v0.14.1 (asyncapi#242)

* feat: added testing for new (asyncapi#212)

* docs: add Samridhi-98 as a contributor for test (asyncapi#248)

* ci: update global workflows (asyncapi#246)

* chore(release): v0.15.0 (asyncapi#249)

* feat: migrate to latest oclif version (asyncapi#203)

* chore: update bot name from codeowners file (asyncapi#247)

* ci: update global workflows (asyncapi#250)

* Create test.yml

* Update test.yml

* Update test.yml

* Update test.yml

* Update test.yml

* Update test.yml

Co-authored-by: Abir <[email protected]>
Co-authored-by: Lukasz Gornicki <[email protected]>
Co-authored-by: Maciej Urbańczyk <[email protected]>
Co-authored-by: asyncapi-bot <[email protected]>
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Samriddhi <[email protected]>
Co-authored-by: asyncapi-bot <[email protected]>
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicmatatjahu magicmatatjahu magicmatatjahu approved these changes

@derberg derberg Awaiting requested review from derberg

Assignees
No one assigned
Labels
ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Souvikns @magicmatatjahu @derberg @asyncapi-bot