Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle AsyncAPI v3 for diff command #1596

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

aayushmau5
Copy link
Member

Description

  • Updates diff package to version 0.5.0
  • Handles diff for AsyncAPI v3 documents
  • Adds new test for AsyncAPI v3 document and fixes existing tests

Related issue(s)

asyncapi/diff#154

Copy link

changeset-bot bot commented Dec 16, 2024

🦋 Changeset detected

Latest commit: 7e8e631

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@asyncapi/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aayushmau5
Copy link
Member Author

@derberg We can close #1595 in favour of this PR since it updates the diff package as well

@aeworxet
Copy link
Contributor

@asyncapi/bounty_team

@asyncapi-bot asyncapi-bot added the bounty AsyncAPI Bounty program related label label Dec 17, 2024
Copy link
Collaborator

@Shurtu-gal Shurtu-gal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shurtu-gal
Copy link
Collaborator

/rtm

@asyncapi-bot asyncapi-bot merged commit 8ae33c4 into asyncapi:master Dec 20, 2024
23 checks passed
@Shurtu-gal
Copy link
Collaborator

@aayushmau5 just a query, should I add diff command functionality between different versions as a TODO feature (Not asking you to do it just was curious if it is possible at all)

@aayushmau5
Copy link
Member Author

@Shurtu-gal we can add that feature as a TODO and see if there's any way we can implement that feature later :)

@Shurtu-gal
Copy link
Collaborator

Great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty AsyncAPI Bounty program related label ready-to-merge
Projects
Status: Completed
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants