Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update @asyncapi/optimizer to 1.0.3 version and others #1509

Conversation

aeworxet
Copy link
Contributor

@aeworxet aeworxet commented Sep 5, 2024

This PR is a clone of #1503 created just to pass the frozen automerge mechanism.

@Shurtu-gal
Copy link
Collaborator

I suppose workflow is not able to setup a clean install properly @aeworxet.

@aeworxet aeworxet force-pushed the fix-update-asyncapi-optimizer-to-1-0-3-version-and-others branch from d370b24 to fada34f Compare September 5, 2024 05:47
@aeworxet
Copy link
Contributor Author

aeworxet commented Sep 5, 2024

Error: node_modules/@types/lodash/common/object.d.ts(1026,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1031,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1041,46): error TS1005: '?' expected.

is due to this issue
DefinitelyTyped/DefinitelyTyped#69932

I changed

-    "typescript": "4.6.4"
+    "typescript": "^4.6.4"  //  <-- added a caret

and tests started passing.

Does this change break anything?

@Shurtu-gal
Copy link
Collaborator

Does this change break anything?

It should not as ^ is used for backward compatible releases.

@aeworxet aeworxet force-pushed the fix-update-asyncapi-optimizer-to-1-0-3-version-and-others branch from fada34f to df76c92 Compare September 5, 2024 20:48
Copy link

sonarqubecloud bot commented Sep 5, 2024

@aeworxet
Copy link
Contributor Author

aeworxet commented Sep 5, 2024

Asked just in case. It might had been hard-locked on that version for a reason. 🤷

Copy link
Collaborator

@Shurtu-gal Shurtu-gal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shurtu-gal
Copy link
Collaborator

/rtm

@asyncapi-bot asyncapi-bot merged commit aa07003 into asyncapi:master Sep 6, 2024
11 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.3.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

@aeworxet aeworxet deleted the fix-update-asyncapi-optimizer-to-1-0-3-version-and-others branch September 6, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants