chore: migrate github-action to cli #1487
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
@asyncapi/bounty_team |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
/u |
|
@akshatnema any blockers being faced by you? |
|
There is no update as I'm researching around the fact on how to manage GitHub Action for CLI. @Shurtu-gal and @derberg proposals require different configurations, which in fact means we need to have the same package.json for both CLI and it's respective GitHub action. I'm currently looking at how to use only one configuration and one package.json. Although the matter looks simple, it will take time to try different approaches, so if I don't achieve a break-through in the nearest couple of days, I'll ask for the Timeline Extension. |
|
but the GH action do not need package.json as it is bash and docker based only. So no need for monorepo afaik - I think we talked about it |
|
@derberg @Shurtu-gal ok so should we do it in a manner that we completely remove the package.json from github action? Since, there is no need of a separate package.json, our whole github action depends on the working of |
That's correct. If I remember correctly the package.json was there just to support the workflows already present. |
github-action/Dockerfile
Outdated
| RUN addgroup -S myuser && adduser -S myuser -G myuser | ||
|
|
||
| # Install necessary packages | ||
| RUN apk add --no-cache bash git chromium |
Check notice
Code scanning / SonarCloud
Arguments in long RUN instructions should be sorted Low
|
@akshatnema sonarcloud is complaining about the Dockerfile building on a image with root as the default user. Maybe the user being added could be used for further steps through I may have missed out on this during migrating to bash. |
Shurtu-gal
changed the title
|
/u |
| - name: Build Docker image and export | ||
| uses: docker/build-push-action@v5 | ||
| with: | ||
| context: . |
There was a problem hiding this comment.
The context should be different I believe as the DockerFile is inside github-action folder.
Shurtu-gal
requested review from
Souvikns,
Amzani and
asyncapi-bot-eve
as code owners
|
@aeworxet this issue is pretty complicated as some things related to containerizing part is still not working and we still have to do the automation of version locking and bumping. @akshatnema is also pretty new to the CLI repo so is it possible to reclassify this bounty as |
|
Shurtu-gal
changed the title
* chore: update package-lock.json * fix: add package-lock.json (asyncapi#1542) * chore: migrate github-action to cli (asyncapi#1487) * New Github action added for cli * Added new files in the github-action * removed monorepo style for github action * Updated github action with Dockerfile changes * added command to pack cli for linux, docker build command * added test-workflow for github-action * chore: fix docker context * chore: change docker context * fix: dockerfile * changed dockerfile * fix: dockerfile * Converted Dockerfile into multi stages * added github-action folder * added assets folder to github action image * deleted act file script * removed asyncapi.yaml file from .gitignore * corrected output file for workflow * updated Dockerfile * added bundle file * changed bundle files * Updated README * updated output bundle directory --------- Co-authored-by: asyncapi-bot <[email protected]> Co-authored-by: Ashish Padhy <[email protected]> * feat: update oclif to v4 (asyncapi#1546) * feat: update oclif to v4 * chore: removed unused dependencies * Update myhook.ts * chore: update package-lock.json version (asyncapi#1550) * fix: add description for the start command in AsyncAPI CLI (asyncapi#1534) (asyncapi#1537) Co-authored-by: Ashish Padhy <[email protected]> * chore(release): v2.7.1 (asyncapi#1551) * fix: update npm to latest for windows (asyncapi#1553) * chore(release): v2.7.2 (asyncapi#1554) * Update upload-release-assets.yml --------- Co-authored-by: root <root@LAPTOP-K7PL9FIU> Co-authored-by: Ashish Padhy <[email protected]> Co-authored-by: Akshat Nema <[email protected]> Co-authored-by: asyncapi-bot <[email protected]> Co-authored-by: Taufiq Hassan <[email protected]>
Description
PR to add the github action for cli from https://github.com/asyncapi/github-action-for-cli.
Related issue(s)
asyncapi/github-action-for-cli#396