Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: generate models for v3 through Modelina CLI #1376

Merged
merged 17 commits into from
Jun 7, 2024
Merged

feat!: generate models for v3 through Modelina CLI #1376

merged 17 commits into from
Jun 7, 2024

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Apr 19, 2024 •
edited
Loading

Description

This PR enables #883 to generate models through Modelina CLI and replaces #1155.

Related issue(s)
Fixes #1376
Blocked by #1228
Blocked by asyncapi/modelina#1952
Blocked by asyncapi/modelina#2008
Blocked by asyncapi/modelina#2010
Blocked by asyncapi/modelina#2009

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

This was referenced Apr 19, 2024
Closed
Closed
@devilkiller-ag
Copy link
Member

devilkiller-ag commented Apr 29, 2024 •
edited
Loading

Hi @jonaslagoni, thanks for opening this PR, I was facing some issues while trying to integrate the Modelina CLI to AsyncAPI CLI when I tried to work on this last month. This PR will help me to learn what's the right way of tackling this task. 😄

@Amzani
Copy link
Collaborator

Amzani commented May 14, 2024

@devilkiller-ag #1228 is ready for review and should unblock your PR

@devilkiller-ag
Copy link
Member

Thanks @Amzani. @jonaslagoni, what's your thought on this? Both the PRs that were blocking this have been merged.

@jonaslagoni
Copy link
Member Author

Gonna fix this on Tuesday ✌️

@jonaslagoni jonaslagoni mentioned this pull request May 19, 2024
Closed
@jonaslagoni jonaslagoni marked this pull request as ready for review May 21, 2024 13:14
Amzani
Amzani previously approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@Amzani Amzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :>

@Amzani
Copy link
Collaborator

Amzani commented May 21, 2024

@jonaslagoni some tests are failing
Also what happens to current changes in generate models: (e.g #1437)
Do you ensure that they got integrated in modelina-cli ?

@jonaslagoni
Copy link
Member Author

Do you ensure that they got integrated in modelina-cli ?

Depends on what comes first, if that PR is merged before this I will update this PR, if it's the other way around we just release a new version of Modelina CLI 🙂

@black-snow
Copy link

This will enable us to generate models for asyncapi v3, right? Any ETA?

@jonaslagoni
Copy link
Member Author

This will enable us to generate models for asyncapi v3, right? Any ETA?

ASAP 🙂

@jonaslagoni jonaslagoni requested a review from Amzani June 3, 2024 13:27
@jonaslagoni
Copy link
Member Author

@Amzani should have solved all the problems now 😅

@black-snow
Copy link

ASAP 🙂

My favourite flavour! ASAP with sprinkles of awesome job, man!

Amzani
Amzani previously approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@Amzani Amzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Amzani Amzani mentioned this pull request Jun 5, 2024
Closed
@jonaslagoni
Copy link
Member Author

Let me quickly fix a bug in Modelina that prohibits model generation 🤨 Should be done today but lets see

Shurtu-gal
Shurtu-gal previously approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@Shurtu-gal Shurtu-gal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonaslagoni jonaslagoni mentioned this pull request Jun 6, 2024
Closed
10 tasks
@jonaslagoni jonaslagoni dismissed stale reviews from Shurtu-gal and Amzani via 4c237bc June 7, 2024 08:57
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jonaslagoni jonaslagoni changed the title feat!: integrate Modelina CLI feat!: generate models for v3 through Modelina CLI Jun 7, 2024
@jonaslagoni jonaslagoni requested a review from Amzani June 7, 2024 09:48
peter-rr
peter-rr reviewed Jun 7, 2024
View reviewed changes
Copy link
Member

@peter-rr peter-rr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎸

@jonaslagoni jonaslagoni requested a review from Shurtu-gal June 7, 2024 11:22
Amzani
Amzani approved these changes Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@Amzani Amzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonaslagoni
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 66bf661 into asyncapi:master Jun 7, 2024
14 checks passed
@jonaslagoni jonaslagoni deleted the add_modelina_micro_cli branch June 7, 2024 13:04
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Souvikns Souvikns mentioned this pull request Jul 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peter-rr peter-rr peter-rr left review comments

@Amzani Amzani Amzani approved these changes

@Souvikns Souvikns Awaiting requested review from Souvikns Souvikns is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

@Shurtu-gal Shurtu-gal Awaiting requested review from Shurtu-gal Shurtu-gal is a code owner

Assignees
No one assigned
Labels
ready-to-merge released
Projects
CLI - Kanban
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jonaslagoni @devilkiller-ag @Amzani @black-snow @asyncapi-bot @peter-rr @Shurtu-gal @Souvikns