Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: need to Implement of catch block in the various commands #800

Closed
AayushSaini101 opened this issue Sep 13, 2023 · 7 comments
Closed
Labels
enhancement New feature or request stale

Comments

@AayushSaini101
Copy link
Collaborator

Reason/Context

Please try answering a few of those questions

  • Why do we need this improvement?

Currently, there are empty catch blocks present in the files that need to implement.

image

  • How will this change help?

It is always good to write proper catch block to handle the exceptions properly.

Description

Please try answering few of those questions

  • Will this be a breaking change?
    No, it will not break any functionality of the CLI.
@AayushSaini101 AayushSaini101 added the enhancement New feature or request label Sep 13, 2023
@AayushSaini101 AayushSaini101 changed the title feat: Need to Implement of catch block in the various commands feat: need to Implement of catch block in the various commands Sep 13, 2023
@AyushNautiyalDeveloper
Copy link

@AayushSaini101 I am working on it.

@ayushnau
Copy link
Contributor

ayushnau commented Sep 19, 2023

image

i am wondering if there is no file then we must create a new one. but then what the line no. 167 is doing it doing the same.

@AayushSaini101

@ayushnau
Copy link
Contributor

thanks for the reply in slack.

@ayushnau
Copy link
Contributor

#812 @AayushSaini101 here is the pull request.

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jan 18, 2024
@github-project-automation github-project-automation bot moved this to Backlog in CLI - Kanban Apr 24, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in CLI - Kanban May 17, 2024
@Amzani
Copy link
Collaborator

Amzani commented May 17, 2024

@ayushnau any updates?
cc @AayushSaini101

@AayushSaini101
Copy link
Collaborator Author

@ayushnau any updates? cc @AayushSaini101

@Amzani This was fixed in this PR #812

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
Archived in project
Development

No branches or pull requests

4 participants