-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cli should validate only yml, yaml and json extension files #799
Comments
hi I would like to work on this. @AayushSaini101 please assign this to me. and also project me to correct direction on where can i start to work on this. |
@AyushNautiyalDeveloper, @AayushSaini101 opened the issue and might be working on it so you need to ask him if you want to work on this issue. That being said some points I would like to share about the problem
This is the function that loads and parses the spec file, Line 27 in 4f2412a
If you read the function you will notice that CLI loads the spec from three different ways, from
This is how we are reading the file from the filesystem, we don't really check what format of the file is as long as it is valid YAML or JSON. cli/src/models/SpecificationFile.ts Line 77 in 4f2412a
Since we already have a check for file formats while running the new command makes sense to have it for validation as well. Also, I think we can create a new Error Type called |
hi @AayushSaini101 can I work on this task or it is already worked on? please let me know. |
@AyushNautiyalDeveloper Please take this issue #800 |
Reason/Context
Please try answering a few of those questions
According to the latest version of the CLI, it will generate only yml, yaml and JSON file extensions, but the validate is still validating the files of different extensions like exe etc
The text was updated successfully, but these errors were encountered: