Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add hashcode and equals flags for csharp code generation #583

Merged
merged 3 commits into from
May 24, 2023
Merged

feat: add hashcode and equals flags for csharp code generation #583

merged 3 commits into from
May 24, 2023

Conversation

kaushik-rishi
Copy link
Contributor

Description

  • adds csharpHashcode and csharpEquals flags.

Related issue(s)

@kaushik-rishi
Copy link
Contributor Author

@jonaslagoni

I've added test for hashcode flag and equal flag alone, should i also add a test when both the flags are passed ?

jonaslagoni
jonaslagoni approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its definitely not a bad test to have, but don't think it's required 🙂

Nice job 👍

Still need a code owner to sign off

@kaushik-rishi
Copy link
Contributor Author

@jonaslagoni Would you suggest me to pickup any particular issue, something a bit more challenging ?

@jonaslagoni
Copy link
Member

@kaushik-rishi in the CLI repo or?

@kaushik-rishi
Copy link
Contributor Author

@kaushik-rishi in the CLI repo or?

Open for issues in other repositories as well 😄

@jonaslagoni
Copy link
Member

I dont have anything specific in mind 😄

My best suggestion is to:

  • find a repo you wish to contribute to, or a library you find interesting
  • see if any issue sounds interesting
    • if the issue is not that well described or you have no idea where to begin, ping the maintainers for some clarification
  • play around with the library and make your own suggestions for improvements

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derberg
Copy link
Member

derberg commented May 24, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit c7d730a into asyncapi:master May 24, 2023
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.42.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kaushik-rishi kaushik-rishi mentioned this pull request Jun 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaslagoni jonaslagoni jonaslagoni approved these changes

@derberg derberg derberg approved these changes

@Souvikns Souvikns Awaiting requested review from Souvikns Souvikns is a code owner

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu

@boyney123 boyney123 Awaiting requested review from boyney123

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate overwritten GetHashCode method for C# models
4 participants
@kaushik-rishi @jonaslagoni @derberg @asyncapi-bot