-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate overwritten Equal method for C# models #466
Comments
Hi @jonaslagoni I would like to work on this issue. |
Working on this along with #467 |
@jonaslagoni can we close this issue as well as it's fixed. |
@jonaslagoni this can be closed 😄 |
@kaushik-rishi you have to get a codeowner to do it 😄 |
Oh didn't know who can I request for then? |
You can always find them in the https://github.com/asyncapi/cli/blob/master/CODEOWNERS file 🙂 Every repository has these. |
Reason/Context
In Modelina for C#, you can make it generate the models with the Equal method overwritten, this should be possible through the CLI.
To do this I suggest we add a flag called
csharpEqual
as a boolean. If true the generator should include the following options:Which should be added here:
cli/src/commands/generate/models.ts
Line 137 in 438de07
These will be the generated results: https://github.com/asyncapi/modelina/blob/master/examples/csharp-generate-json-serializer/__snapshots__/index.spec.ts.snap
Remember to also add a test here:
cli/test/commands/generate/models.test.ts
Line 95 in 438de07
Related documentation: https://github.com/asyncapi/modelina/blob/master/docs/languages/Csharp.md#generate-models-with-equals-and-gethashcode-methods
Feel free to reach out if you have any questions or get stuck!
The text was updated successfully, but these errors were encountered: