-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
asyncapi --version
should also output version of other asyncapi dependencies
#361
Comments
Yeah, I agree with this, also since CLI is implementing other tools, should CLI be able to install specific versions of the tool on the go? So users can change the generator version they want to work with commands like |
@Souvikns I don't think so that it's good idea, due to fact that API for given tool can change between version, so for example, in newest parser we switch from singleton parser instance to the Parser as class, so API and also exports from module changed, so calling |
ok, since we agree on that, the question is not on technical details. afaik |
What would be better, to have a section in the release documentation talking about the different version of asyncapi tools it depends on, Or have it in CLI's |
|
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
this one is still very much needed |
This issue is part of the AsyncAPI Bounty Program, interested contributors need to follow the guidelines below to ensure fairness and timely completion of assigned tasks: Task AssignmentThe assignment of tasks will be prioritized in the following order:
We encouraged everyone to apply as long as the task is for you (falls under your skill set). We will not be using the first comment - get assigned method for assignments. Instead, we will provide 3 days to consider all individuals interested before assigning any bounty task. DeadlineTo maintain accountability and ensure the timely completion of the deadline for this task will be 4- 6 weeks from the date of assignment. If a contributor requires an extension on their task, it should be communicated and approved by the maintainer. Issue Tracking and UpdatesContributors must provide weekly updates on the task they are working on to help maintainers stay informed of progress. If a contributor fails to provide an update, they will be reminded via a ping. If a contributor fails to provide an update after three pings over three weeks, we will assume they have silently dropped the issue, and it will be reassigned to someone else. Issue Drop-outsAny contributor who drops an assigned issue will be penalized and will not be eligible to participate in the bounty program for 6 months. We understand that unforeseen circumstances can arise, and dropping an assigned issue may be unavoidable in some cases. However, we believe that enforcing this penalty is necessary to ensure the effectiveness of the bounty program, respect maintainer time, and honor the efforts of other contributors who could have solved the issue but were unable to do so due to the drop-out. We encourage all contributors to follow these guidelines to ensure a fair and timely completion of tasks assigned through our bounty program. |
I agree with the suggestion that the asyncapi --version command should output the version of other AsyncAPI dependencies. This would provide users with more comprehensive information about the software's version and the underlying components it relies on. It would also help users to identify any potential compatibility issues between their version of AsyncAPI and its dependencies. Overall, this would be a valuable addition to the command and would enhance the user experience. |
I would like to work on this issue. |
I think two issues (this + #38) is just enough to not jeopardize delivery of both. So I would propose addition to Bounty Program rules: 'Bounty Program Participant can choose up to two any Bounty issues for simultaneous delivery.' |
@aeworxet please add your comment to https://github.com/orgs/asyncapi/discussions/541#discussioncomment-5652222 so we do not forget @thulieblack as we did not have a rule to block someone from doing 2 issues at the same time, are you ok that @aeworxet will pick 2? |
As long as @aeworxet delivers I don't think that will be a problem😊 |
Switch
Would that do? |
And there is no way to override or extend it? I think it anyway do not work well, as -v is not supported afaik |
Possibility to override/customize And it doesn't seem to be possible without making manual patches to
Another user at some moment proposed two workarounds for this issue, but approach #1 uses deprecated packages and approach #2 uses hook functionality which basically does the same thing I had already proposed to do without a hook (hook is invoked on execution of a separate command and I don't see a necessity to introduce one more layer of abstraction.) Example code: aeworxet@5bc9ce0 |
hey, yeah, I think
|
Bounty Program Timeline
Please note that dates represent deadlines, not specific dates, so if the goal is reached sooner, it's better. |
@aeworxet congrats on completing your first bounty issue @thulieblack on to you, not sure if you have some copy/paste message for people on how to claim bounty payment, so yeah, leaving that communication up to you @aeworxet I guess you will make a submission in one call once context-related issue is completed |
Hey @aeworxet , congratulations on completing your first bounty issue. This is how'll claim your payment:
|
So instead of version of AsyncAPI CLI only we should also list generator and others
https://github.com/asyncapi/generator/pull/818/files#diff-c1cc304e56dd03cbb5cf65c32d83c9b7ab069800b2ce780249ac87d320e76789 is one of main reasons. For example in case of generator and templates, it is super important to know that you are using proper generator version. So we need an easy way for CLI user to check that out with one command
Thoughts? @Souvikns @magicmatatjahu @boyney123
The text was updated successfully, but these errors were encountered: