-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add x-origin
property
#147
feat: add x-origin
property
#147
Conversation
@KhudaDad414 @derberg |
e141d82
to
30a0f3c
Compare
db76cf3
to
e41e46c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aeworxet Tests are failing for some reason. 🤔
For anyone waiting on this PR who doesn't want to fork, and doesn't need
|
3f8201a
to
682de39
Compare
92b449e
to
a54dc11
Compare
This PR is ready for merge, but it should be merged only AFTER asyncapi/optimizer#216 is merged (it will be merged only to |
9416fa4
to
2ebd3ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you should remove some of the previous changes.
b10b1af
to
0892753
Compare
18673fb
to
72aafe3
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
/rtm |
🎉 This PR is included in version 0.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR adds the generation of the property
x-origin
during the dereferencing process.Property
x-origin
is used for origin tracing inBundler
and component naming inOptimizer
.It originated from this comment in a year-long discussion:
Thus, property
x-origin
contains historical values of dereferenced$ref
s, which are also used byOptimizer
starting from its version v1.0.0, to give meaningful names to components it moves through the AsyncAPI Document.Partial resolution of #141