Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable additional properties for topicConfigurationObject #228

Closed
wants to merge 3 commits into from
Closed

feat: enable additional properties for topicConfigurationObject #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
480994e
feat: enable additional properties for topicConfigurationObject
gokerakc Nov 30, 2023
34d7142
docs: updated kafka bindings version
gokerakc Dec 4, 2023
fd2d0b0
Merge branch 'master' into gokerakc-patch-1
gokerakc Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions kafka/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ This document defines how to describe Kafka-specific information on AsyncAPI.

## Version

Current version is `0.4.0`.
Current version is `0.5.0`.


<a name="server"></a>
Expand Down Expand Up @@ -88,7 +88,7 @@ Field Name | Type |
<a name="topicConfigurationDeleteRetentionBytes"></a>`delete.retention.ms` | integer | The [`delete.retention.ms`](https://kafka.apache.org/documentation/#topicconfigs_delete.retention.ms) configuration option. | OPTIONAL | see kafka documentation
<a name="topicConfigurationMaxMessageBytes"></a>`max.message.bytes` | integer | The [`max.message.bytes`](https://kafka.apache.org/documentation/#topicconfigs_max.message.bytes) configuration option. | OPTIONAL | see kafka documentation

This object MUST contain only the properties defined above.
This object MAY contain the properties defined above including optional additional properties.

##### Example

Expand Down
4 changes: 2 additions & 2 deletions kafka/json_schemas/channel.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"topicConfiguration" : {
"description": "Topic configuration properties that are relevant for the API.",
"type": "object",
"additionalProperties": false,
"additionalProperties": true,
"properties": {
"cleanup.policy": {
"description": "The [`cleanup.policy`](https://kafka.apache.org/documentation/#topicconfigs_cleanup.policy) configuration option.",
Expand Down Expand Up @@ -78,4 +78,4 @@
}
]
}