-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adapt MQTT bindings to v3 #205
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaslagoni
requested review from
derberg,
fmvilas,
dalelane,
smoya,
char0n and
asyncapi-bot-eve
as code owners
June 13, 2023 17:49
This was referenced Jun 13, 2023
jonaslagoni
changed the title
feat!: adapt MQTT bindings to v3
feat: adapt MQTT bindings to v3
Jun 22, 2023
fmvilas
requested changes
Jun 26, 2023
Co-authored-by: Fran Méndez <[email protected]>
dalelane
approved these changes
Jul 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fmvilas
approved these changes
Jul 7, 2023
Thanks folks 👍 |
/rtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adapts the MQTT bindings to v3. This first round of review is just for the general structure changes.
TODO right before final review:
TODO after merge:
Related issue(s)
Related to #182