feat: add topicConfiguration property to channel object #171
Conversation
thake
requested review from
KhudaDad414,
lbroudoux and
dalelane
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
There was a problem hiding this comment.
overall, I really like this - I think it's going to be super helpful.
I have a few minor nit-picks over how we word the constraints, but just trying to make sure we phrase it in a way that is easy for anyone to understand.
My only real concern is about the inclusion of cleanup.policy - I'm not sure whether clients really need to know about this one.
|
@dalelane, thanks for your fast and very good review 👍 . I've updated the README.md to always point to the kafka documentation for constraints. |
|
Is there anything left to do here? Are any more approvals needed? I'm unsure of the proceedings 😏 |
@thake Sorry for the delay and thanks for your PR. I really like your proposition: it adds useful complements! |
|
@dalelane @KhudaDad414 All checks are green. I think we're good for merging! Let me know so that I can proceed. |
|
/rtm |
resolves #163 by introducing a new
topicConfigurationproperty to the channel object.