Field are optional by default but should be required

[fmvilas]

Describe the bug

When using Avro, the fields are always required unless a default value is given. Currently, fields are not being tagged as required when converted to JSON Schema.

Expected behavior

Unless a default value is given, a field should be required.

[M3lkior]

Hi @fmvilas , the default attribut for simple type (not only enum) in avro schema is handle ?

I have a similar issue concernant the nullable fields :

I think that not nullable field must be set as required by default, contrary to ["null", "string"] type for example.

So required field declaration :

{"name": "SHORT_PRODUCT_DESCRIPTION", "type": "string", "doc": "A short description of the product"},

Optional field declaration :

        
{"name": "SHORT_PRODUCT_DESCRIPTION", "type": ["null", "string"], "doc": "A short description of the product."},

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

[M3lkior]

i support required fields in #82 . We just need to validate the required rules (default value or not null union)

[M3lkior]

i work on them as hacktoberfest issue

[M3lkior]

Solved by 053be5a in the https://github.com/asyncapi/avro-schema-parser/releases/tag/v0.6.0

[Rustamw888]

Hi @fmvilas , the default attribut for simple type (not only enum) in avro schema is handle ?

I have a similar issue concernant the nullable fields :

I think that not nullable field must be set as required by default, contrary to ["null", "string"] type for example.

So required field declaration :

{"name": "SHORT_PRODUCT_DESCRIPTION", "type": "string", "doc": "A short description of the product"},

Optional field declaration :

        
{"name": "SHORT_PRODUCT_DESCRIPTION", "type": ["null", "string"], "doc": "A short description of the product."},

Hi, I use { "name": "SHORT_PRODUCT_DESCRIPTION", "type": "string", "doc": "A short description of the product"}, to make the field mandatory. but when I pass null, the test ignores it and passes. if the data type is long, then null is no longer passed as expected, since the field I want to make mandatory. so how do I do this for data type string?