feat: add config options to override pub sub label text #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BTOdell
requested review from
magicmatatjahu,
derberg,
fmvilas and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
magicmatatjahu
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
LGTM! @BTOdell Sorry for such a delay and thanks for the contribution!
|
Kudos, SonarCloud Quality Gate passed!
|
|
/rtm |
|
🎉 This PR is included in version 1.0.0-next.41 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated documentation. All tests pass. Not sure how I would go about adding new tests for this feature...
Description
Changes proposed in this pull request:
Reason for feature
At my company, Megh Computing Inc, we are using AsyncAPI to document our WebSocket API. Our API does not operate in a typical PUB-SUB way; clients do not "publish" data to the endpoints. Any data sent to an endpoint is to configure that WebSocket session and specify the async events that the client wishes to receive. We have received feedback from our customers that the terminology label "PUB" is confusing. Our solution is to rename the "PUB" label to "CONF", but the tool currently does not support overriding that label text.