Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove lowercase in pattern #550

Merged

Conversation

M3lkior
Copy link

@M3lkior M3lkior commented Feb 16, 2022

Related to #549

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@M3lkior M3lkior changed the base branch from master to next February 16, 2022 15:50
@magicmatatjahu magicmatatjahu changed the title Fix/549 remove lowercase in pattern fix: remove lowercase in pattern Feb 17, 2022
@magicmatatjahu
Copy link
Member

@M3lkior Thanks for PR! It looks good. However, could you push empty commit? I see that you created PR with master destination and then switch to the next and SonerCloud didn't recognize that and create analize based on master.

…xpected

the pattern is set to lowercase so some pattern expression like [A-Z]{3} are displayed as [a-z]{3} that is not correct

Close asyncapi#549
@M3lkior M3lkior force-pushed the fix/549-remove-lowercase-in-pattern branch from 8f6a90f to 7001b6e Compare February 17, 2022 17:46
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@M3lkior
Copy link
Author

M3lkior commented Feb 17, 2022

done @magicmatatjahu;

Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0-next.34 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants