Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add collapse button for nested subschemas in the Schema component #514

Conversation

magicmatatjahu
Copy link
Member

@magicmatatjahu magicmatatjahu commented Jan 13, 2022

Description

Changes proposed in this pull request:

Add collapse button for nested subschemas in the Schema component. Button is next to the normal collapse button. If the user presses the extra button, all subschemas will open/close (depending if subschemas are opened/closed).

Live preview: https://3000-emerald-trout-ukylr6te.ws-eu25.gitpod.io/

Examples:

Collapsed deep:

image

Collapsed only one level

image

Related issue(s)
Resolves #440

@magicmatatjahu magicmatatjahu added enhancement New feature or request area/library Related to all activities around Library package labels Jan 13, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@magicmatatjahu magicmatatjahu marked this pull request as ready for review January 13, 2022 13:15
@magicmatatjahu
Copy link
Member Author

@mcturco I know that you're not a maintainer of that branch but could you check only design of that new button (the right one) and UX and write something about it, do you accept/reject?

@mcturco
Copy link
Member

mcturco commented Feb 17, 2022

@magicmatatjahu Hi!

🤔

I am wondering if it would be more clear if instead of the double arrows we have text that says Expand all and Collapse all as I don't feel like the double arrows would signify that action very well.

The preview link doesn't work so I can't test it, but do we need this expand/collapse at every schema level? I mean, if we show the entire payload will that be too much in some use cases? These are all things that we are going to work on from a user experience POV In the near future, so maybe we don't stress too much about it right now.

@magicmatatjahu
Copy link
Member Author

It will be handled in #604

@magicmatatjahu magicmatatjahu deleted the next-branches/deep-collapsed-button branch May 31, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/library Related to all activities around Library package enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants