Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add prefix for css classes #381

Closed
wants to merge 1 commit into from
Closed

feat: add prefix for css classes #381

wants to merge 1 commit into from

Conversation

magicmatatjahu
Copy link
Member

Description

Changes proposed in this pull request:

Add to all TailwindCSS classes the aui- prefix. Why? More info is in Resolves #369:

In the next version of component we use the TailwindCSS for styling. We don't use the prefixes for TailwindCSS classes used inside the component. It can ends with duplicated classes with other properties than ours in some application - in other words, users can attach to application existing TailwindCSS stylings based on "normal" TailwindCSS class names, so they can override our styles or our styles can override other.

Related issue(s)
Resolves #369
Blocked by #374

@magicmatatjahu magicmatatjahu added enhancement New feature or request area/library Related to all activities around Library package labels Jun 22, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions github-actions bot added the stale label Aug 22, 2021
@kaiszybiak kaiszybiak mentioned this pull request Nov 24, 2021
Merged
5 tasks
@kaiszybiak kaiszybiak mentioned this pull request Dec 2, 2021
Merged
@magicmatatjahu
Copy link
Member Author

Fixed by #493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg Awaiting requested review from derberg derberg will be requested when the pull request is marked ready for review derberg is a code owner

@fmvilas fmvilas Awaiting requested review from fmvilas fmvilas will be requested when the pull request is marked ready for review fmvilas is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve will be requested when the pull request is marked ready for review asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
area/library Related to all activities around Library package enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@magicmatatjahu