Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: strictly check if a given part of spec exists and render single message from oneOf #335

Merged
merged 4 commits into from
May 7, 2021
Merged

fix: strictly check if a given part of spec exists and render single message from oneOf #335

merged 4 commits into from
May 7, 2021

Conversation

magicmatatjahu
Copy link
Member

@magicmatatjahu magicmatatjahu commented May 6, 2021 •
edited
Loading

Description

Changes proposed in this pull request:

  • Check if given part of spec exists, if not, then don't return this part (changed parts are required to define in spec, but check it to be sure).
  • Render first index of oneOf messages... hasMultipleMessages has broken meaning... 🤦🏼

Related issue(s)
See also asyncapi/html-template#191

@magicmatatjahu magicmatatjahu added bug Something isn't working area/library Related to all activities around Library package labels May 6, 2021
@magicmatatjahu magicmatatjahu changed the title fix: strictly check if a given part of spec exists fix: strictly check if a given part of spec exists and render single message from oneOf May 6, 2021
@magicmatatjahu magicmatatjahu mentioned this pull request May 6, 2021
Closed
@magicmatatjahu magicmatatjahu requested a review from derberg May 6, 2021 22:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 7, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@magicmatatjahu magicmatatjahu merged commit aa03538 into asyncapi:next May 7, 2021
@magicmatatjahu magicmatatjahu deleted the next-branches/fix-191 branch May 7, 2021 09:07
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0-next.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg approved these changes

Assignees
No one assigned
Labels
area/library Related to all activities around Library package bug Something isn't working released on @next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magicmatatjahu @asyncapi-bot @derberg